Re: [PATCH 4/4] [libmultipath] Update hardware table forHPHSV200

[Hannes Reinecke <hare@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]

Reilly, Stephen (MRO) wrote:
[ Quoting appears to be a lost art ... ]
> 
> Hannes Reinecke wrote:
 >> Reilly, Stephen (MRO) wrote:
>>> The product name does change if the firmware uses 'START_STOP_UNIT' or
>>> ALUA... so why are we adding the revision?
>>
>> Ah, that's news to me.
>> How does the product name change?
 >
> The firmware will change the name
 >
Oh, that's nice.

>> My contacts at HP Boeblingen said that the revision number indicated the 
>> behaviour.
>> What are the names of the fw using START_STOP_UNIT?
> HSV100 and HSV110 EVA3000/5000
EVA is the name of the machine; HSV is the SCSI model name, right?

>> And what are those for using ALUA?
> HSV101, HSV111, HSV200 and HSV210 EVA 3000/5000  EVA4000/6000/8000
> 
What about the old MSA ones? Is there a firmware upgrade available?
If so, will the name change there, too?

>> And irrespective of this I think matching by revision is still a valid 
>> addition to the hardware table mechanism.
> However I would not use it determine the START_STOP_UNIT or ALUA implementation
> 
I was under the impression that the name would stay the same. If that's 
not the case then of course we should match onto the name.

Please check the attached patch if it updates the hwtables correctly.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke			hare@suse.de
SuSE Linux Products GmbH		S390 & zSeries
Maxfeldstraße 5				+49 911 74053 688
90409 Nürnberg				http://www.suse.de

[-- Attachment #2: hp-hwtable-update --]
[-- Type: text/plain, Size: 2961 bytes --]

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index ac126c0..2fd6fac 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -75,21 +75,6 @@ static struct hwentry default_hw[] = {
 		.checker_name  = HP_SW,
 	},
 	{
-		.vendor        = "(COMPAQ|HP)",
-		.product       = "(MSA|HSV)1.*",
-		.getuid        = DEFAULT_GETUID,
-		.getprio       = NULL,
-		.features      = DEFAULT_FEATURES,
-		.hwhandler     = "1 hp_sw",
-		.selector      = DEFAULT_SELECTOR,
-		.pgpolicy      = MULTIBUS,
-		.pgfailback    = FAILBACK_UNDEF,
-		.rr_weight     = RR_WEIGHT_NONE,
-		.no_path_retry = NO_PATH_RETRY_UNDEF,
-		.minio         = DEFAULT_MINIO,
-		.checker_name  = HP_SW,
-	},
-	{
 		.vendor        = "HP",
 		.product       = "A6189A",
 		.getuid        = DEFAULT_GETUID,
@@ -105,13 +90,13 @@ static struct hwentry default_hw[] = {
 		.checker_name  = READSECTOR0,
 	},
 	{
-		.vendor        = "HP",
-		.product       = "HSV20.*",
-		.revision      = "[123].*",
+		/* EVA 3000/5000 with old firmware */
+		.vendor        = "(COMPAQ|HP)",
+		.product       = "(MSA|HSV)1.0.*",
 		.getuid        = DEFAULT_GETUID,
 		.getprio       = NULL,
 		.features      = DEFAULT_FEATURES,
-		.hwhandler     = DEFAULT_HWHANDLER,
+		.hwhandler     = "1 hp_sw",
 		.selector      = DEFAULT_SELECTOR,
 		.pgpolicy      = MULTIBUS,
 		.pgfailback    = FAILBACK_UNDEF,
@@ -121,15 +106,15 @@ static struct hwentry default_hw[] = {
 		.checker_name  = HP_SW,
 	},
 	{
-		.vendor        = "HP",
-		.product       = "HSV20.*",
-		.revision      = "[^123].*",
+		/* EVA 3000/5000 with new firmware */
+		.vendor        = "(COMPAQ|HP)",
+		.product       = "(MSA|HSV)1.1.*",
 		.getuid        = DEFAULT_GETUID,
 		.getprio       = "/sbin/mpath_prio_alua /dev/%n",
 		.features      = DEFAULT_FEATURES,
 		.hwhandler     = DEFAULT_HWHANDLER,
 		.selector      = DEFAULT_SELECTOR,
-		.pgpolicy      = MULTIBUS,
+		.pgpolicy      = GROUP_BY_PRIO,
 		.pgfailback    = -FAILBACK_IMMEDIATE,
 		.rr_weight     = RR_WEIGHT_NONE,
 		.no_path_retry = NO_PATH_RETRY_UNDEF,
@@ -137,15 +122,16 @@ static struct hwentry default_hw[] = {
 		.checker_name  = TUR,
 	},
 	{
+		/* EVA 4000/6000/8000 */
 		.vendor        = "HP",
-		.product       = "HSV21.*",
+		.product       = "HSV2.*",
 		.getuid        = DEFAULT_GETUID,
 		.getprio       = "/sbin/mpath_prio_alua /dev/%n",
 		.features      = DEFAULT_FEATURES,
 		.hwhandler     = DEFAULT_HWHANDLER,
 		.selector      = DEFAULT_SELECTOR,
 		.pgpolicy      = GROUP_BY_PRIO,
-		.pgfailback    = FAILBACK_UNDEF,
+		.pgfailback    = -FAILBACK_IMMEDIATE,
 		.rr_weight     = RR_WEIGHT_NONE,
 		.no_path_retry = NO_PATH_RETRY_UNDEF,
 		.minio         = DEFAULT_MINIO,
@@ -249,7 +235,7 @@ static struct hwentry default_hw[] = {
 		.rr_weight     = RR_WEIGHT_NONE,
 		.no_path_retry = NO_PATH_RETRY_UNDEF,
 		.minio         = DEFAULT_MINIO,
-		.checker_name  = READSECTOR0,
+		.checker_name  = TUR,
 	},
 	{
 		.vendor        = "HITACHI",

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]