Re: [PATCH] clear garbage after CDBs on SG_IO

[Tejun Heo <htejun@gmail.com>]

Andrew Morton wrote:
> On Thu, 16 Nov 2006 09:52:27 +0900
> Tejun Heo <htejun@gmail.com> wrote:
> 
>> ATAPI devices transfer fixed number of bytes for CDBs (12 or 16).
>> Some ATAPI devices choke when shorter CDB is used and the left bytes
>> contain garbage.  Block SG_IO cleared left bytes but SCSI SG_IO
>> didn't.  This patch makes SCSI SG_IO clear it and simplify CDB
>> clearing in block SG_IO.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>> Cc: Mathieu Fluhr <mfluhr@nero.com>
>>
>> diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c
>> index 2dc3264..cac7f18 100644
>> --- a/block/scsi_ioctl.c
>> +++ b/block/scsi_ioctl.c
>> @@ -286,9 +286,8 @@ static int sg_io(struct file *file, requ
>>  	 * fill in request structure
>>  	 */
>>  	rq->cmd_len = hdr->cmd_len;
>> +	memset(req->cmd, 0, BLK_MAX_CDB); /* ATAPI hates garbage after CDB */
> 
> s/req/rq/ makes the compiler happier there.

Yeap, apparently.  Sorry.  Last minute copy and paste w/ comment. 
Arggh... No change is ever safe.

-- 
tejun