From: Jeff Mahoney <jeffm@suse.com>
To: Jeff Mahoney <jeffm@jeffreymahoney.com>,
linux-fsdevel@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-ext4@vger.kernel.org, Eric Sandeen <esandeen@redhat.com>
Subject: Re: [PATCH] ext3: htree entry integrity checking
Date: Thu, 16 Nov 2006 19:28:32 -0500 [thread overview]
Message-ID: <455D0230.7040709@suse.com> (raw)
In-Reply-To: <20061116222747.GT6012@schatzie.adilger.int>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Andreas Dilger wrote:
> On Nov 16, 2006 11:50 -0500, Jeff Mahoney wrote:
>> Currently, if a corrupted directory entry with rec_len=0 is encountered,
>> we still trust that the data is valid. This can cause an infinite loop
>> in htree_dirblock_to_tree() since the iteration loop will never make any
>> progress.
>
> Actually, I think Eric Sandeen was working on similar fixes already, and
> instead of doing a per-item check each time we look at the entry it does
> a full-block check the first time it is read (as ext2 does).
>
>> This fixes the problem described at:
>> http://projects.info-pull.com/mokb/MOKB-10-11-2006.html
>
> Would also be good to CC linux-ext4, where the ext3 maintainers live.
Ok, thanks. If that's already in -mm, I'll use that one.
- -Jeff
- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org
iD8DBQFFXQIwLPWxlyuTD7IRApH7AJ9+/SFmd9bf8E741wvxw/6vdrUrdwCeJNEG
eHZMo5RWUrLW5iDEqehjRlI=
=lGRM
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2006-11-17 0:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-16 16:50 [PATCH] ext3: htree entry integrity checking Jeff Mahoney
2006-11-16 22:27 ` Andreas Dilger
2006-11-16 22:33 ` Eric Sandeen
2006-11-17 0:28 ` Jeff Mahoney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=455D0230.7040709@suse.com \
--to=jeffm@suse.com \
--cc=esandeen@redhat.com \
--cc=jeffm@jeffreymahoney.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.