From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jim Fehlig <jfehlig@novell.com>
Subject: [PATCH] [xend] Fix on-wire response for RPCs that
	return void
Date: Fri, 17 Nov 2006 16:34:41 -0700
Message-ID: <455E4711.1030902@novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="------------060500060808000208050501"
Return-path: <xen-devel-bounces@lists.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

This is a multi-part message in MIME format.
--------------060500060808000208050501
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

The legacy apis return a value of None on success, which was being 
converted to an illegal (as per Xen API spec) value of 'nil' in the 
xmlrpc response.  An example of the invalid on-wire response:

<methodResponse>
  <params>
    <param>
      <value>
        <struct>
          <member>
            <name>Status</name>
            <value><string>Success</string></value>
          </member>
          <member>
            <name>Value</name>
            <value><nil/></value>
          </member>
        </struct>
      </value>
    </param>
  </params>
</methodResponse>


The Xen IPI spec states that destroy, hard_shutdown, pause, resume, 
start, suspend, and unpause return void.  This patch makes it so and 
permits proper parsing of the response by clients (libxen) that follow 
the spec.

Jim


--------------060500060808000208050501
Content-Type: text/x-patch;
 name="xend-success-retval.patch"
Content-Transfer-Encoding: base64
Content-Disposition: inline;
 filename="xend-success-retval.patch"

IyBIRyBjaGFuZ2VzZXQgcGF0Y2gKIyBVc2VyIGpmZWhsaWdAamZlaGxpZzIucHJvdm8ubm92
ZWxsLmNvbQojIERhdGUgMTE2MzgwNTY3NCAyNTIwMAojIE5vZGUgSUQgNWQxNjhiOGU3NDNh
NDMyYmE3MTlkYmI5OTBlNzcxNjRjNThiMDgwZAojIFBhcmVudCAgZjBiYTQ1OTA2NWQzMmI2
MWM5ZDA0Y2NkZTU3ODdlNDhlMjNiZTc4MgpUaGUgbGVnYWN5IGFwaXMgcmV0dXJuIGEgdmFs
dWUgb2YgTm9uZSBvbiBzdWNjZXNzLCB3aGljaCB3YXMgYmVpbmcgY29udmVydGVkIHRvIGEg
dmFsdWUgb2YgJ25pbCcgaW4gdGhlIHhtbHJwYyByZXNwb25zZS4KVGhlIFhlbiBJUEkgc3Bl
YyBzdGF0ZXMgdGhhdCBkZXN0cm95LCBoYXJkX3NodXRkb3duLCBwYXVzZSwgcmVzdW1lLCBz
dGFydCwgc3VzcGVuZCwgYW5kIHVucGF1c2UgcmV0dXJuIHZvaWQuICBUaGlzIHBhdGNoIG1h
a2VzIGl0IHNvIGFuZCBwZXJtaXRzIHByb3BlciBwYXJzaW5nIG9mIHRoZSByZXNwb25zZSBi
eSBjbGllbnRzIChsaWJ4ZW4pIHRoYXQgZm9sbG93IHRoZSBzcGVjLgoKU2lnbmVkLW9mZi1i
eTogSmltIEZlaGxpZyA8amZlaGxpZ0Bub3ZlbGwuY29tPgoKZGlmZiAtciBmMGJhNDU5MDY1
ZDMgLXIgNWQxNjhiOGU3NDNhIHRvb2xzL3B5dGhvbi94ZW4veGVuZC9YZW5kQVBJLnB5Ci0t
LSBhL3Rvb2xzL3B5dGhvbi94ZW4veGVuZC9YZW5kQVBJLnB5CVRodSBOb3YgMTYgMTg6NDc6
MjggMjAwNiAtMDgwMAorKysgYi90b29scy9weXRob24veGVuL3hlbmQvWGVuZEFQSS5weQlG
cmkgTm92IDE3IDE2OjIxOjE0IDIwMDYgLTA3MDAKQEAgLTI1Nyw4ICsyNTcsOCBAQCBkZWYg
ZG9fdm1fZnVuYyhmbl9uYW1lLCB2bV9yZWYsICphcmdzKToKICAgICAiIiIKICAgICB4ZW5k
b20gPSBYZW5kRG9tYWluLmluc3RhbmNlKCkKICAgICBmbiA9IGdldGF0dHIoeGVuZG9tLCBm
bl9uYW1lKQotICAgIHJldHVybiB4ZW5fYXBpX3N1Y2Nlc3MoeGVuZG9tLmRvX2xlZ2FjeV9h
cGlfd2l0aF91dWlkKAotICAgICAgICBmbiwgdm1fcmVmLCAqYXJncykpCisgICAgeGVuZG9t
LmRvX2xlZ2FjeV9hcGlfd2l0aF91dWlkKGZuLCB2bV9yZWYsICphcmdzKQorICAgIHJldHVy
biB4ZW5fYXBpX3N1Y2Nlc3Nfdm9pZCgpCiAKIAogY2xhc3MgWGVuZEFQSToK
--------------060500060808000208050501
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

--------------060500060808000208050501--