From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <45617342.8020504@domain.hid> Date: Mon, 20 Nov 2006 10:20:02 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1163784779.4980.47.camel@domain.hid> <455E025B.5030906@domain.hid> <1163790315.4980.73.camel@domain.hid> <455E0940.7070705@domain.hid> <1163800682.4980.81.camel@domain.hid> In-Reply-To: <1163800682.4980.81.camel@domain.hid> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig176072A835B1C23461FCB426" Sender: jan.kiszka@domain.hid Subject: [Xenomai-core] Re: XENO_OPT_DEBUG impact List-Id: "Xenomai life and development \(bug reports, patches, discussions\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: rpm@xenomai.org Cc: xenomai-core This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig176072A835B1C23461FCB426 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Philippe Gerum wrote: > On Fri, 2006-11-17 at 20:10 +0100, Jan Kiszka wrote: >> Philippe Gerum wrote: >>> On Fri, 2006-11-17 at 19:41 +0100, Jan Kiszka wrote: >>>> I'm currently seeing two potential "misuses" of the common switch: >>>> >>>> - the posix skin (Gilles, how heavy-weighted are those checks?) >>>> =3D> CONFIG_XENO_OPT_DEBUG_POSIX >>>> >>>> - CONFIG_XENO_SPINLOCK_DEBUG =3D> CONFIG_XENO_OPT_DEBUG_SPINLOCK >>>> >>>> Both should be explicitly controllable in Kconfig. >>>> >>> Nack for CONFIG_XENO_OPT_DEBUG_SPINLOCK. Most of the issue we tracked= >>> with Gilles regarding the domain migration code had side-effects on t= he >>> nucleus lock. So having CONFIG_XENO_OPT_DEBUG enabled for identifying= >>> internal state weirdnesses - like those triggered by migration bugs -= >>> implies enabling the spinlock watchdogs too. >> Ok, if it only makes sense to have both enabled at the same time, then= >> let us create XENO_OPT_DEBUG_NUCLEUS. It should include both, but it >> shall not be automatically on when, say, only XENO_OPT_DEBUG_RTDM is >> required. >=20 > No objection. >=20 Looking at the spinlock debugging code: it serves two inseparable purposes, a watchdog for stuck locks + lock statistics. The latter make this feature pop up when XENO_OPT_STATS are set on a SMP box - rather surprising effect. Do we still need the stats? If not, I would kick them out in favour of using the latency tracer for such analysis, making spinlock debugging a real pure debug feature. Jan --------------enig176072A835B1C23461FCB426 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFYXNCniDOoMHTA+kRAgdoAJ95p6uS+Y4UZmo0wAfo9lj183+dvgCfWjH4 P/jrJ1KegO5s815NJYxDv6E= =M3OX -----END PGP SIGNATURE----- --------------enig176072A835B1C23461FCB426--