All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] rockchip: dts: rk3328: add aliases for mmc controller
Date: Tue, 23 May 2017 22:29:33 +0200	[thread overview]
Message-ID: <4561995.VGFlTTDuPh@phil> (raw)
In-Reply-To: <7c3bd978-0236-33a6-46fd-77038ee627d6@rock-chips.com>

Hi Kever, Tom,

Am Dienstag, 23. Mai 2017, 14:32:44 CEST schrieb Kever Yang:
>      This is not from kernel, seems the kernel mmc driver does not 
> support aliases now,
> 
> thought I hope they both support the aliases for ordering.

there was a lengthy discussion about the pros and cons of ordering
mmc devices last year [0].

With the outcome that explicit ordering via aliases is not desired
and the argument being that mmc devices are not so different from
usb storage or scsi/sata devices whose ordering is random all the time.


Heiko

[0] https://lkml.org/lkml/2016/4/29/621


> Thanks,
> - Kever
> On 05/23/2017 05:18 AM, Tom Rini wrote:
> > On Thu, May 18, 2017 at 04:05:20PM +0800, Kever Yang wrote:
> >
> >> Add aliases for mmc controller to get a fixed order with
> >> emmc at index 0 and sdmmc at index 1.
> >>
> >> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> >> ---
> >>
> >>   arch/arm/dts/rk3328.dtsi | 3 +++
> >>   1 file changed, 3 insertions(+)
> >>
> >> diff --git a/arch/arm/dts/rk3328.dtsi b/arch/arm/dts/rk3328.dtsi
> >> index 8a98ee3..e1af030 100644
> >> --- a/arch/arm/dts/rk3328.dtsi
> >> +++ b/arch/arm/dts/rk3328.dtsi
> >> @@ -25,6 +25,9 @@
> >>   		i2c1 = &i2c1;
> >>   		i2c2 = &i2c2;
> >>   		i2c3 = &i2c3;
> >> +		mmc0 = &emmc;
> >> +		mmc1 = &sdmmc;
> >> +		mmc2 = &sdmmc_ext;
> >>   	};
> >>   
> >>   	cpus {
> > Does this come from re-syncing the dts with the kernel?  Are they going
> > to the kernel?  Thanks!
> >
> 
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot
> 

  parent reply	other threads:[~2017-05-23 20:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-18  8:05 [U-Boot] [PATCH] rockchip: dts: rk3328: add aliases for mmc controller Kever Yang
2017-05-22 20:26 ` Simon Glass
2017-06-09  0:48   ` Kever Yang
2017-06-09 12:27     ` Simon Glass
2017-06-15 19:21       ` sjg at google.com
2017-05-22 21:18 ` Tom Rini
2017-05-23  6:32   ` Kever Yang
2017-05-23 11:47     ` Tom Rini
2017-05-23 20:29     ` Heiko Stuebner [this message]
2017-05-23 20:32       ` Tom Rini
2017-05-23 21:03       ` Mark Kettenis
2017-05-23 21:14         ` Tom Rini
2017-05-23 21:27           ` Heiko Stuebner
2017-05-23 22:18             ` Andreas Färber
2017-05-24  0:44               ` Simon Glass
2017-05-24  8:18                 ` Heiko Stuebner
2017-05-24 12:56                   ` Tom Rini
2017-06-01  3:11                     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4561995.VGFlTTDuPh@phil \
    --to=heiko@sntech.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.