From: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
To: Jan Kiszka <jan.kiszka@domain.hid>
Cc: xenomai-core <xenomai@xenomai.org>
Subject: Re: [Xenomai-core] [PATCH 3/3] control POSIX skin debugging independently
Date: Tue, 21 Nov 2006 10:59:33 +0100 [thread overview]
Message-ID: <4562CE05.70900@domain.hid> (raw)
In-Reply-To: <456236E5.5060203@domain.hid>
Jan Kiszka wrote:
> Following the logic of per-subsystem debug feature control, this patch
> introduces a separate kconfig switch XENO_OPT_POSIX_DEBUG and updates
> the involved source files.
I find the "if(XENO_DEBUG(FOO))" notation make it hard to understand
that the piece of code that follows is disabled at compilation time,
#ifdef CONFIG_XENO_OPT_FOO_DEBUG is easier to read. This also avoid the
rather inelegant
#ifndef CONFIG_XENO_OPT_POSIX_DEBUG
#define CONFIG_XENO_OPT_POSIX_DEBUG 0
#endif
Now about the Posix skin patch, in my opinion the Posix skin debug
should be enabled by default, because these printks are the indication
that there is something wrong in the user code: some objects were
created but not destroyed.
--
Gilles Chanteperdrix
next prev parent reply other threads:[~2006-11-21 9:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-20 23:14 [Xenomai-core] [PATCH 3/3] control POSIX skin debugging independently Jan Kiszka
2006-11-21 9:59 ` Gilles Chanteperdrix [this message]
2006-11-21 11:26 ` Jan Kiszka
2006-11-21 16:27 ` Thomas Lockhart
2006-11-21 19:13 ` Jan Kiszka
2006-11-22 7:21 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4562CE05.70900@domain.hid \
--to=gilles.chanteperdrix@xenomai.org \
--cc=jan.kiszka@domain.hid \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.