From: Brian King <brking@us.ibm.com>
To: dougg@torque.net
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
Joern Quillman <quillman@fbihome.de>,
linux-scsi@vger.kernel.org
Subject: Re: Spinup of SCSI Disks: allow_restart won't work on 2.6.18
Date: Tue, 21 Nov 2006 08:41:27 -0600 [thread overview]
Message-ID: <45631017.4080601@us.ibm.com> (raw)
In-Reply-To: <45624E30.5080605@torque.net>
Douglas Gilbert wrote:
> Stefan Richter wrote:
>> I think the solution is easy: Replace if (sdp->type != TYPE_DISK) by
>>
>> if (sdp->type != TYPE_DISK && sdp->type != TYPE_RBC)
>
> ... but why have the condition at all? What other peripheral
> device type should the _sd_ driver be handling??
Currently, sd attaches TYPE_DISK, TYPE_RBC, and TYPE_MOD devices. I
don't have a problem with removing the check and letting userspace
do what they want to do.
Brian
--
Brian King
eServer Storage I/O
IBM Linux Technology Center
next prev parent reply other threads:[~2006-11-21 14:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-17 17:38 Spinup of SCSI Disks: allow_restart won't work on 2.6.18 Joern Quillman
2006-11-17 21:44 ` Joern Quillmann
2006-11-17 23:34 ` Stefan Richter
2006-11-17 23:36 ` Stefan Richter
2006-11-20 10:52 ` Joern Quillman
2006-11-20 11:48 ` Stefan Richter
2006-11-20 22:32 ` Joern Quillman
2006-11-20 23:53 ` Stefan Richter
2006-11-21 0:54 ` Douglas Gilbert
2006-11-21 4:20 ` James Bottomley
2006-11-21 8:12 ` Stefan Richter
2006-11-21 14:41 ` Brian King [this message]
2006-11-21 20:34 ` [PATCH] scsi: sd: configurable allow_restart attribute for all device types Stefan Richter
2006-11-21 1:09 ` Spinup of SCSI Disks: allow_restart won't work on 2.6.18 Joern Quillmann
2006-11-21 20:49 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45631017.4080601@us.ibm.com \
--to=brking@us.ibm.com \
--cc=dougg@torque.net \
--cc=linux-scsi@vger.kernel.org \
--cc=quillman@fbihome.de \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.