All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <jbeulich@novell.com>
To: Mats Petersson <Mats.Petersson@amd.com>
Cc: xen-devel@lists.xensource.com
Subject: RE: [PATCH] support protected mode mmio with non-zero CS base
Date: Wed, 22 Nov 2006 12:24:50 +0100	[thread overview]
Message-ID: <45644192.76E4.0078.0@novell.com> (raw)
In-Reply-To: <907625E08839C4409CE5768403633E0B018E1749@sefsexmb1.amd.com>

>Yes, but it's also possibly incorrect if the machine is in "big
>realmode", which is an entirely valid way to run code in x86 processors,
>and I think it's better to fix it "properly" than to have to fix it
>again when someone finds another fault in the code, because someone
>wrote some code differently. 

I meanwhile got convinced by Keir that this is indeed the better way.

>The next problem will of course be that data-fetches where the segment
>base is non-zero. I think the only case where that is likely to happen
>in mmio is for MOVS instructions, as everything else is presumably using
>the faulting address to know where the MMIO address is. But I'm OK with
>not fixing this right now. 

I intend to, and I suppose I'll find more places. The base address use is
only one part for string instructions - the more involved (or perhaps better
the one causing more overhead) is that for repeated ones, we'll now have
to do limit checks, as the CPU will have checked only the first item.

Jan

  reply	other threads:[~2006-11-22 11:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-21 16:55 [PATCH] support protected mode mmio with non-zero CS base Jan Beulich
2006-11-21 17:03 ` Petersson, Mats
2006-11-22  7:36   ` Jan Beulich
2006-11-22  7:51     ` Keir Fraser
2006-11-22 11:15     ` Petersson, Mats
2006-11-22 11:24       ` Jan Beulich [this message]
2006-11-22 11:44         ` Keir Fraser
2006-11-22 12:46           ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45644192.76E4.0078.0@novell.com \
    --to=jbeulich@novell.com \
    --cc=Mats.Petersson@amd.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.