From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH] support protected mode mmio with non-zero CS base Date: Wed, 22 Nov 2006 13:46:21 +0100 Message-ID: <456454AD.76E4.0078.0@novell.com> References: <45644192.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Mats Petersson , Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org >>> Keir Fraser 22.11.06 12:44 >>> >On 22/11/06 11:24, "Jan Beulich" wrote: >>> Yes, but it's also possibly incorrect if the machine is in "big >>> realmode", which is an entirely valid way to run code in x86 processors, >>> and I think it's better to fix it "properly" than to have to fix it >>> again when someone finds another fault in the code, because someone >>> wrote some code differently. >> >> I meanwhile got convinced by Keir that this is indeed the better way. > >Actually I disagree with you, but the patch was a strict improvement so I Maybe a mere misunderstanding - I meant to say that I got convinced to have no real mode specific code there (and I changed my internal patch, which got meanwhile extended quite a bit [will post later once I tested VMX], accordingly). >checked it in as-is. But the realmode-specific path will go away in a future >patch, I'm quite sure. Jan