From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: RE: string mmio/pio across page boundaries Date: Thu, 23 Nov 2006 13:19:18 +0100 Message-ID: <45659FD6.76E4.0078.0@novell.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Xin B Li , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org >>> "Li, Xin B" 23.11.06 12:36 >>> >> >>When preparing arguments for send_mmio_req() or send_pio_req() in hvm >>where a single iteration crosses a page boundary, the value to >>be written is copied from guest memory, but I can't see where the value >>read is copied to guest memory. Is this case simply missing? >> > >in send_mmio_req or send_pio_req, there is no request crossing a page >boundary, since it's already converted. I didn't say in these two functions, I said when preparing the arguments for them. Would you look at this again, please? Similarly for the updating of ecx that I asked about in a subsequent mail. >Are you using an old source tree, I don't see such code, and we have >sent a patch to clean that code before xen 3.0.3. >I think the logic is correct now. It isn't - I'm working on a 3.0.3 based tree right now. But yes, I see that -unstable has this fixed. I should have checked... Jan