From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lelvem-ot02.ext.ti.com (lelvem-ot02.ext.ti.com [198.47.23.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A73319D8A3; Mon, 21 Apr 2025 14:58:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.23.235 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745247511; cv=none; b=VODD80Yn8/n+Lgay0kEsWvnIpmbM0bEn3MZ7aIgozHO2qCC0e20AtjoU6RGwtXHiDD5v0KpxNXT/A470popCdnnccsv+KY4u/A+9b9kKdxw2lr5U50vsEkSIsW+2cutJMCJwIC2JnRcCR3wn6dzhatVV6sqECg/DVi9h/1ZcA1w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745247511; c=relaxed/simple; bh=sZSQgOEuCPiFDieMBbiZHyYKYD9C/QvWUKurZFqFdyA=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=hcT8ew/9/+beKWHuN+Tnv+tZrXUOjY2IQm4coMgqSdcelEuI5DaL9hGvcAAetD/DuNhMdVjhY4yLhsQ0q6kYlH3/xyUOyGyNoHJv8VDluD7Fn2nH463LrPjm1aVxnpgaqboPH5JRC17qcR8vid0lxkdK+1r+h09R53TB/XjD44Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=xXE8daUO; arc=none smtp.client-ip=198.47.23.235 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="xXE8daUO" Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelvem-ot02.ext.ti.com (8.15.2/8.15.2) with ESMTPS id 53LEwJ0N1662263 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 21 Apr 2025 09:58:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1745247499; bh=Ae+j7es8df45TLkOKtkmbdkI0hXkJaSWH4KNRCISUgA=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=xXE8daUON2SHTxhTdnIhpozXLlY2yQdSlQjnENwikmyBUDqxUZpnKmVl9geLpnkb8 ZqXI3ifBhQBLewbsmw0DmT1AG4Q5etXJtIVmlRb+GXZaoIPaOwca12adyCXTnRWYo5 yTNPf4Q01NfRxMVpDTOk8ven7RpAX89RqMizsydE= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 53LEwJqC032679 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 21 Apr 2025 09:58:19 -0500 Received: from DLEE115.ent.ti.com (157.170.170.26) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 21 Apr 2025 09:58:18 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 21 Apr 2025 09:58:19 -0500 Received: from [10.249.42.149] ([10.249.42.149]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 53LEwIPK109405; Mon, 21 Apr 2025 09:58:18 -0500 Message-ID: <4567caaa-3cf6-47a1-beeb-53ee29562ce5@ti.com> Date: Mon, 21 Apr 2025 09:58:18 -0500 Precedence: bulk X-Mailing-List: linux-remoteproc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 13/33] remoteproc: k3: Refactor .kick rproc ops into common driver To: Beleswar Padhi , , CC: , , , , , , , , References: <20250417182001.3903905-1-b-padhi@ti.com> <20250417182001.3903905-14-b-padhi@ti.com> Content-Language: en-US From: Andrew Davis In-Reply-To: <20250417182001.3903905-14-b-padhi@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea On 4/17/25 1:19 PM, Beleswar Padhi wrote: > The .kick rproc ops implementations in TI K3 R5, DSP and M4 remoteproc > drivers sends a mailbox message to the remote processor in the same > way. Refactor the implementations into a common function > 'k3_rproc_kick()' in the ti_k3_common.c driver. > > Signed-off-by: Beleswar Padhi > --- > v10: Changelog: > None > > Link to v9: > https://lore.kernel.org/all/20250317120622.1746415-12-b-padhi@ti.com/ > > drivers/remoteproc/ti_k3_common.c | 25 ++++++++++++++++++++++ > drivers/remoteproc/ti_k3_common.h | 1 + > drivers/remoteproc/ti_k3_dsp_remoteproc.c | 22 +------------------ > drivers/remoteproc/ti_k3_m4_remoteproc.c | 26 +---------------------- > drivers/remoteproc/ti_k3_r5_remoteproc.c | 17 +-------------- > 5 files changed, 29 insertions(+), 62 deletions(-) > > diff --git a/drivers/remoteproc/ti_k3_common.c b/drivers/remoteproc/ti_k3_common.c > index 7b45e3b416186..aace308b49b0e 100644 > --- a/drivers/remoteproc/ti_k3_common.c > +++ b/drivers/remoteproc/ti_k3_common.c > @@ -80,5 +80,30 @@ void k3_rproc_mbox_callback(struct mbox_client *client, void *data) > } > EXPORT_SYMBOL_GPL(k3_rproc_mbox_callback); > > +/* > + * Kick the remote processor to notify about pending unprocessed messages. > + * The vqid usage is not used and is inconsequential, as the kick is performed > + * through a simulated GPIO (a bit in an IPC interrupt-triggering register), > + * the remote processor is expected to process both its Tx and Rx virtqueues. > + */ This comment is wrong. Looks like this is a copy paste error that ended up in every ti_k3_*_remoteproc.c driver. This whole "simulated GPIO" thing is only true for the K2 DSP (keystone_remoteproc.c), all the K3 devices have proper mailbox interrupts. Anyway, no need to remove it here, this patch is just a refactor and since it was already in every driver you are factoring this out from I'd suggest fixing it in a later patch. For this patch, Acked-by: Andrew Davis > +void k3_rproc_kick(struct rproc *rproc, int vqid) > +{ > + struct k3_rproc *kproc = rproc->priv; > + struct device *dev = kproc->dev; > + u32 msg = (u32)vqid; > + int ret; > + > + /* > + * Send the index of the triggered virtqueue in the mailbox payload. > + * NOTE: msg is cast to uintptr_t to prevent compiler warnings when > + * void* is 64bit. It is safely cast back to u32 in the mailbox driver. > + */ > + ret = mbox_send_message(kproc->mbox, (void *)(uintptr_t)msg); > + if (ret < 0) > + dev_err(dev, "failed to send mailbox message, status = %d\n", > + ret); > +} > +EXPORT_SYMBOL_GPL(k3_rproc_kick); > + > MODULE_LICENSE("GPL"); > MODULE_DESCRIPTION("TI K3 common Remoteproc code"); > diff --git a/drivers/remoteproc/ti_k3_common.h b/drivers/remoteproc/ti_k3_common.h > index 785bb4b17d02f..6ae7ac4ec5696 100644 > --- a/drivers/remoteproc/ti_k3_common.h > +++ b/drivers/remoteproc/ti_k3_common.h > @@ -89,4 +89,5 @@ struct k3_rproc { > }; > > void k3_rproc_mbox_callback(struct mbox_client *client, void *data); > +void k3_rproc_kick(struct rproc *rproc, int vqid); > #endif /* REMOTEPROC_TI_K3_COMMON_H */ > diff --git a/drivers/remoteproc/ti_k3_dsp_remoteproc.c b/drivers/remoteproc/ti_k3_dsp_remoteproc.c > index 7bd1d5a790cb2..476f4e69d2c11 100644 > --- a/drivers/remoteproc/ti_k3_dsp_remoteproc.c > +++ b/drivers/remoteproc/ti_k3_dsp_remoteproc.c > @@ -24,26 +24,6 @@ > > #define KEYSTONE_RPROC_LOCAL_ADDRESS_MASK (SZ_16M - 1) > > -/* > - * Kick the remote processor to notify about pending unprocessed messages. > - * The vqid usage is not used and is inconsequential, as the kick is performed > - * through a simulated GPIO (a bit in an IPC interrupt-triggering register), > - * the remote processor is expected to process both its Tx and Rx virtqueues. > - */ > -static void k3_dsp_rproc_kick(struct rproc *rproc, int vqid) > -{ > - struct k3_rproc *kproc = rproc->priv; > - struct device *dev = rproc->dev.parent; > - mbox_msg_t msg = (mbox_msg_t)vqid; > - int ret; > - > - /* send the index of the triggered virtqueue in the mailbox payload */ > - ret = mbox_send_message(kproc->mbox, (void *)msg); > - if (ret < 0) > - dev_err(dev, "failed to send mailbox message (%pe)\n", > - ERR_PTR(ret)); > -} > - > /* Put the DSP processor into reset */ > static int k3_dsp_rproc_reset(struct k3_rproc *kproc) > { > @@ -342,7 +322,7 @@ static void *k3_dsp_rproc_da_to_va(struct rproc *rproc, u64 da, size_t len, bool > static const struct rproc_ops k3_dsp_rproc_ops = { > .start = k3_dsp_rproc_start, > .stop = k3_dsp_rproc_stop, > - .kick = k3_dsp_rproc_kick, > + .kick = k3_rproc_kick, > .da_to_va = k3_dsp_rproc_da_to_va, > }; > > diff --git a/drivers/remoteproc/ti_k3_m4_remoteproc.c b/drivers/remoteproc/ti_k3_m4_remoteproc.c > index a1bcc4b265dfe..8a6917259ce60 100644 > --- a/drivers/remoteproc/ti_k3_m4_remoteproc.c > +++ b/drivers/remoteproc/ti_k3_m4_remoteproc.c > @@ -21,30 +21,6 @@ > #include "ti_sci_proc.h" > #include "ti_k3_common.h" > > -/* > - * Kick the remote processor to notify about pending unprocessed messages. > - * The vqid usage is not used and is inconsequential, as the kick is performed > - * through a simulated GPIO (a bit in an IPC interrupt-triggering register), > - * the remote processor is expected to process both its Tx and Rx virtqueues. > - */ > -static void k3_m4_rproc_kick(struct rproc *rproc, int vqid) > -{ > - struct k3_rproc *kproc = rproc->priv; > - struct device *dev = kproc->dev; > - u32 msg = (u32)vqid; > - int ret; > - > - /* > - * Send the index of the triggered virtqueue in the mailbox payload. > - * NOTE: msg is cast to uintptr_t to prevent compiler warnings when > - * void* is 64bit. It is safely cast back to u32 in the mailbox driver. > - */ > - ret = mbox_send_message(kproc->mbox, (void *)(uintptr_t)msg); > - if (ret < 0) > - dev_err(dev, "failed to send mailbox message, status = %d\n", > - ret); > -} > - > static int k3_m4_rproc_ping_mbox(struct k3_rproc *kproc) > { > struct device *dev = kproc->dev; > @@ -448,7 +424,7 @@ static const struct rproc_ops k3_m4_rproc_ops = { > .stop = k3_m4_rproc_stop, > .attach = k3_m4_rproc_attach, > .detach = k3_m4_rproc_detach, > - .kick = k3_m4_rproc_kick, > + .kick = k3_rproc_kick, > .da_to_va = k3_m4_rproc_da_to_va, > .get_loaded_rsc_table = k3_m4_get_loaded_rsc_table, > }; > diff --git a/drivers/remoteproc/ti_k3_r5_remoteproc.c b/drivers/remoteproc/ti_k3_r5_remoteproc.c > index a1dfbe383c13c..dedc9456983e0 100644 > --- a/drivers/remoteproc/ti_k3_r5_remoteproc.c > +++ b/drivers/remoteproc/ti_k3_r5_remoteproc.c > @@ -129,21 +129,6 @@ struct k3_r5_core { > bool released_from_reset; > }; > > -/* kick a virtqueue */ > -static void k3_r5_rproc_kick(struct rproc *rproc, int vqid) > -{ > - struct k3_rproc *kproc = rproc->priv; > - struct device *dev = rproc->dev.parent; > - mbox_msg_t msg = (mbox_msg_t)vqid; > - int ret; > - > - /* send the index of the triggered virtqueue in the mailbox payload */ > - ret = mbox_send_message(kproc->mbox, (void *)msg); > - if (ret < 0) > - dev_err(dev, "failed to send mailbox message, status = %d\n", > - ret); > -} > - > static int k3_r5_split_reset(struct k3_rproc *kproc) > { > int ret; > @@ -735,7 +720,7 @@ static const struct rproc_ops k3_r5_rproc_ops = { > .unprepare = k3_r5_rproc_unprepare, > .start = k3_r5_rproc_start, > .stop = k3_r5_rproc_stop, > - .kick = k3_r5_rproc_kick, > + .kick = k3_rproc_kick, > .da_to_va = k3_r5_rproc_da_to_va, > }; >