All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Pei, Yulong" <yulong.pei@intel.com>
Cc: dev@dpdk.org, "Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [PATCH v4] app/testpmd: initialize port_numa and ring_numa
Date: Mon, 01 May 2017 15:35:13 +0200	[thread overview]
Message-ID: <4569052.iy7vOOdIzB@xps> (raw)
In-Reply-To: <9BB6961774997848B5B42BEC655768F810D5A0CA@SHSMSX103.ccr.corp.intel.com>

28/04/2017 10:30, Wu, Jingjing:
> From: Pei, Yulong
> > 
> > Previous numa_support = 0 by default, it need to add --numa to testpmd
> > command line to enable numa, so port_numa and ring_numa were initialized at
> > function launch_args_parse(), now testpmd change numa_support = 1 as default,
> > so port_numa and ring_numa also need to initialize by default, otherwise port-
> > >socket_id will be probed to wrong value.
> > 
> > Fixes: 999b2ee0fe45 ("app/testpmd: enable NUMA support by default")
> > 
> > Signed-off-by: Yulong Pei <yulong.pei@intel.com>
> 
> You forgot "fix" in title if the patch is fixing a problem.
> Anyway, the change is OK.
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>

Please rebase on top of http://dpdk.org/commit/3ab64341d
and check if the patch needs to be reworked.
The check of port_numa array below is weird.

PS: please use --in-reply-to for v5.

  reply	other threads:[~2017-05-01 13:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-28  2:01 [PATCH v4] app/testpmd: initialize port_numa and ring_numa Yulong Pei
2017-04-28  8:30 ` Wu, Jingjing
2017-05-01 13:35   ` Thomas Monjalon [this message]
2017-05-03 10:27 ` [PATCH] app/testpmd: fix port_numa and ring_numa not initialize issue Yulong Pei
2017-05-03 10:29 ` [PATCH v5] " Yulong Pei
2017-05-06  0:52   ` Wu, Jingjing
2017-05-06  8:30     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4569052.iy7vOOdIzB@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=yulong.pei@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.