All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jarek Poplawski <jarkao2@o2.pl>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH][NET_SCHED] sch_cbq: deactivating when grafting, purging etc.
Date: Mon, 27 Nov 2006 11:39:58 +0100	[thread overview]
Message-ID: <456AC07E.6000606@trash.net> (raw)
In-Reply-To: <20061127104140.GA2866@ff.dom.local>

Jarek Poplawski wrote:
> On Mon, Nov 27, 2006 at 10:55:39AM +0100, Patrick McHardy wrote:
> 
>>Your patch looks good, but it conflicts with my patches.
> 
> 
> I know, but I wasn't sure which version this changes
> are needed for. If there will be something more to do,
> name the version, please. 

Just add it on top of them. They apply cleanly to the current
-git tree.

>>One thing I forgot to mention is that it should also have
>>a callback for deactivating classes when their childs
>>become empty. If you do that you can just call
>>disc_tree_decrement_qlen in graft/delete, which will take
>>care of the qlen decrement and class deactivation.
> 
>  
> If I understand correctly I should apply this to 
> the version after your patch (plus the missing cbq part
> of "endless loops"). I'll try.

Thanks.

  reply	other threads:[~2006-11-27 10:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-27  6:56 [PATCH][NET_SCHED] sch_cbq: deactivating when grafting, purging etc Jarek Poplawski
2006-11-27  9:55 ` Patrick McHardy
2006-11-27 10:41   ` Jarek Poplawski
2006-11-27 10:39     ` Patrick McHardy [this message]
2006-11-28  6:37       ` Jarek Poplawski
2006-11-30 12:22         ` Patrick McHardy
2006-12-08  8:27           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=456AC07E.6000606@trash.net \
    --to=kaber@trash.net \
    --cc=jarkao2@o2.pl \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.