From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: remove unused HSM_ST_UNKNOWN
Date: Tue, 28 Nov 2006 04:00:54 -0500 [thread overview]
Message-ID: <456BFAC6.3070403@pobox.com> (raw)
In-Reply-To: <20061117030511.GC2184@htj.dyndns.org>
Tejun Heo wrote:
> HSM_ST_UNKNOWN is not used anywhere. Its value is zero and supposed
> to serve sanity check purpose but HSM_ST_IDLE is used for that
> purpose. This unused state causes confusion. After a port is
> initialized but before the first command is executed, the idle hsm
> state is UNKNOWN. However, once a command has completed, the idle hsm
> state is IDLE. This defeats sanity check in ata_pio_task() for the
> first command.
>
> This patch removes HSM_ST_UNKNOWN and consequently make HSM_ST_IDLE
> the default state.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
ACK
prev parent reply other threads:[~2006-11-28 9:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-17 3:05 [PATCH] libata: remove unused HSM_ST_UNKNOWN Tejun Heo
2006-11-28 9:00 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=456BFAC6.3070403@pobox.com \
--to=jgarzik@pobox.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.