All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 2/2 UPDATED] libata: make sure IRQ is cleared after ata_bmdma_freeze()
Date: Tue, 28 Nov 2006 04:03:30 -0500	[thread overview]
Message-ID: <456BFB62.2000906@pobox.com> (raw)
In-Reply-To: <20061117032422.GF2184@htj.dyndns.org>

Tejun Heo wrote:
> Now that BMDMA status is recorded in irq handler.  ata_bmdma_freeze()
> is free to manipulate host status.  Under certain circumstances, some
> controllers (ICH7 in enhanced mode w/ IRQ shared) raise IRQ when CTL
> register is written to and ATA_NIEN doesn't mask it.
> 
> This patch makes ata_bmdma_freeze() clear all pending IRQs after
> freezing a port.  This change makes explicit clearing in
> ata_device_add() unnecessary and thus kills it.  The removed code was
> SFF-specific and was in the wrong place.
> 
> Note that ->freeze() handler is always called under ap->lock held and
> irq disabled.  Even if CTL manipulation causes stuck IRQ, it's cleared
> immediately.  This should be safe (enough) even in SMP environment.
> More correct solution is to mask the IRQ from IRQ controller but that
> would be an overkill.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>

ACK


  reply	other threads:[~2006-11-28  9:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-17  3:06 [PATCH 1/2] libata: move BMDMA host status recording from EH to interrupt handler Tejun Heo
2006-11-17  3:07 ` [PATCH 2/2] libata: make sure IRQ is cleared after ata_bmdma_freeze() Tejun Heo
2006-11-17  3:24   ` [PATCH 2/2 UPDATED] " Tejun Heo
2006-11-28  9:03     ` Jeff Garzik [this message]
2006-11-17  3:27   ` [PATCH 2/2] " Mark Lord
2006-11-17  3:44     ` Tejun Heo
2006-11-28  9:01 ` [PATCH 1/2] libata: move BMDMA host status recording from EH to interrupt handler Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=456BFB62.2000906@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=htejun@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.