From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] libata: set IRQF_SHARED for legacy PCI IDE IRQs
Date: Tue, 28 Nov 2006 04:04:29 -0500 [thread overview]
Message-ID: <456BFB9D.2050706@pobox.com> (raw)
In-Reply-To: <20061117072227.GG2184@htj.dyndns.org>
Tejun Heo wrote:
> There are machines out there which share legacy PCI IDE IRQs w/ other
> devices. libata SFF interrupt/HSM code is ready for shared IRQ and
> has been setting IRQF_SHARED for devices in native PCI mode. Device
> in legacy mode is still a PCI device and thus supposedly uses
> active-low level triggered IRQ.
>
> Machines with such setup should be quite rare and w/o this flag libata
> is likely to fail loading and render the system unuseable. Also, IDE
> driver has been setting IRQF_SHARED for devices in legacy mode for a
> looooong time.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
>
> Jeff, I couldn't find a generic way to check whether an IRQ is
> confiured as level or edge. All these legacy mess are pretty much for
> the BIOS to figure out, so let's just do what IDE has been doing.
>
> Thanks.
ACK
probably appropriate for #upstream-fixes, but IMO it's too late into -rc
to apply such a change without wide testing
prev parent reply other threads:[~2006-11-28 9:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-17 7:22 [PATCH] libata: set IRQF_SHARED for legacy PCI IDE IRQs Tejun Heo
2006-11-28 9:04 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=456BFB9D.2050706@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.