All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Triplett <josh@freedesktop.org>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: linux-sparse@vger.kernel.org
Subject: Re: [RFC] <op>= mishandling
Date: Tue, 28 Nov 2006 12:45:33 -0800	[thread overview]
Message-ID: <456C9FED.8000102@freedesktop.org> (raw)
In-Reply-To: <20061124071247.GO3078@ftp.linux.org.uk>

[-- Attachment #1: Type: text/plain, Size: 693 bytes --]

Al Viro wrote:
> commit 5a627ec02342727b151712acc9c752a8e4f12da0
> Author: Linus Torvalds <torvalds@ppc970.osdl.org>
> Date:   Sat Nov 6 20:10:22 2004 -0700
> 
>     Don't do assignment replacement at type evaluation time.
> 
> was too optimistic.  Here's a trivial example of the things going
> wrong with it:
[snip various detailed examples of this going horribly wrong.]
> I'm fixing that crap right now; if somebody has objections against the
> above - please, yell.

No objections; please do.

When you supply the fix, can you please also include one or more test cases
for the validation directory which demonstrate the incorrect evaluation?

Thanks,
Josh Triplett


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

      reply	other threads:[~2006-11-28 20:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-24  7:12 [RFC] <op>= mishandling Al Viro
2006-11-28 20:45 ` Josh Triplett [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=456C9FED.8000102@freedesktop.org \
    --to=josh@freedesktop.org \
    --cc=linux-sparse@vger.kernel.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.