All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Harald Welte <laforge@netfilter.org>,
	Netfilter Development Mailinglist
	<netfilter-devel@lists.netfilter.org>
Subject: Re: [PATCH 1/3][CONNTRACK] Introduce flag facilities to take over TCP connections
Date: Tue, 28 Nov 2006 23:23:51 +0100	[thread overview]
Message-ID: <456CB6F7.6010909@trash.net> (raw)
In-Reply-To: <456C6D3C.9060909@netfilter.org>

Pablo Neira Ayuso wrote:
> Hi Patrick,
> 
> I reworked the previous patch based on some of your suggestions. Let me
> know what you think.

We're almost there :)

> +	/* skip window scale and flags dump if hard tracking is by passed */

minor nitpick: bypassed

> +	NFA_PUT(skb, CTA_PROTOINFO_TCP_FLAGS_ORIGINAL, sizeof(u_int8_t),
> +		&ct->proto.tcp.seen[0].flags);
> +	
> +	NFA_PUT(skb, CTA_PROTOINFO_TCP_FLAGS_REPLY, sizeof(u_int8_t),
> +		&ct->proto.tcp.seen[1].flags);

The attributes should contain the same data type in both directions,
the receive side expects a structure.

  reply	other threads:[~2006-11-28 22:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-28 17:09 [PATCH 1/3][CONNTRACK] Introduce flag facilities to take over TCP connections Pablo Neira Ayuso
2006-11-28 22:23 ` Patrick McHardy [this message]
2006-11-29 14:27   ` Pablo Neira Ayuso
2006-11-29 14:29     ` Patrick McHardy
2006-11-29 15:07       ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=456CB6F7.6010909@trash.net \
    --to=kaber@trash.net \
    --cc=laforge@netfilter.org \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.