From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: Christoph Lameter <clameter@sgi.com>,
linux-mm@kvack.org, Linus Torvalds <torvalds@osdl.org>
Subject: Re: Slab: Remove kmem_cache_t
Date: Wed, 29 Nov 2006 19:04:12 +1100 [thread overview]
Message-ID: <456D3EFC.8030701@yahoo.com.au> (raw)
In-Reply-To: <20061128234104.9e23b4b1.akpm@osdl.org>
Andrew Morton wrote:
> On Wed, 29 Nov 2006 18:23:34 +1100
> Nick Piggin <nickpiggin@yahoo.com.au> wrote:
>
>
>>>Any module which calls kmem_cache_create() needs to save its return value
>>>into some storage. That storage has type `struct kmem_cache *', or
>>>kmem_cache_t *.
>>
>>And why can't it include linux/slab.h to get the proper definitions
>>(+/- typdefs)?
>
>
> argh.
>
> Because then you need to include slab.h in header files which don't otherwise need it.
Oh so it isn't a dependency problem, or one that prevents a cleaner
slab bootstrapping process... Just that you'd like to skimp out on
some includes. Why didn't you say that from the start? ;)
Personally I prefer to include declarations when they are needed,
but whatever. I'll drop it, now that I know the justification for
the patch.
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-11-29 8:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-29 2:49 Slab: Remove kmem_cache_t Christoph Lameter
2006-11-29 3:06 ` Andrew Morton
2006-11-29 4:06 ` Nick Piggin
2006-11-29 3:32 ` Christoph Lameter
2006-11-29 4:42 ` Nick Piggin
2006-11-29 3:48 ` Nick Piggin
2006-11-29 4:06 ` Andrew Morton
2006-11-29 4:38 ` Linus Torvalds
2006-11-29 5:51 ` Nick Piggin
2006-11-29 15:48 ` Linus Torvalds
2006-11-30 1:40 ` Nick Piggin
2006-11-30 1:59 ` Linus Torvalds
2006-11-30 2:14 ` Nick Piggin
2006-11-30 2:37 ` Linus Torvalds
2006-11-30 2:51 ` Nick Piggin
2006-11-29 6:21 ` Nick Piggin
2006-11-29 6:21 ` Nick Piggin
2006-11-29 16:11 ` Linus Torvalds
2006-11-29 16:11 ` Linus Torvalds
2006-11-29 5:41 ` Nick Piggin
2006-11-29 6:24 ` Andrew Morton
2006-11-29 6:41 ` Nick Piggin
2006-11-29 7:08 ` Andrew Morton
2006-11-29 7:23 ` Nick Piggin
2006-11-29 7:41 ` Andrew Morton
2006-11-29 8:04 ` Nick Piggin [this message]
2006-11-29 16:23 ` Linus Torvalds
2006-11-30 1:44 ` Nick Piggin
2006-11-29 19:16 ` Christoph Lameter
2006-11-29 8:50 ` Peter Zijlstra
2006-11-29 19:27 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=456D3EFC.8030701@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=linux-mm@kvack.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.