All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Christoph Lameter <clameter@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	akpm@osdl.org, linux-mm@kvack.org,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	mpm@selenic.com, Manfred Spraul <manfred@colorfullife.com>
Subject: Re: [RFC] Extract kmalloc.h and slob.h from slab.h
Date: Thu, 30 Nov 2006 15:18:36 +1100	[thread overview]
Message-ID: <456E5B9C.6030504@yahoo.com.au> (raw)
In-Reply-To: <Pine.LNX.4.64.0611291946320.19578@schroedinger.engr.sgi.com>

Christoph Lameter wrote:
> On Thu, 30 Nov 2006, Nick Piggin wrote:
> 
> 
>>OK, slab_defs.h and slob_defs.h would work, wouldn't it? That seems to be
>>the standard pattern used when alternatives become too numerous / complex
>>to be in a single file.
> 
> 
> Maybe better define a standard API and provide empty functions for slob?

There is a standard API, isn't there? It is the API used by the callers.
Ie. the one in slab.h, before slob came along.

So yes, we *have* to have all allocators using the same kmem_cache_t
framework. I don't see how a different API between slab and slob could
work?

> I think it would be feasable to have all slab allocators work within the 
> same kmem_cache_* framework. The kmalloc approaches are all different 
> though. So i would need kmalloc_slob and kmalloc_slab?

I see, I didn't realise kmalloc was different as well. I guess you could
follow the same approach. Probably don't bother splitting it, and just
move the kmalloc definitions to slab_defs.h / slob_defs.h?

-- 
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2006-11-30  4:18 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-28  6:33 [RFC] Extract kmalloc.h and slob.h from slab.h Christoph Lameter
2006-11-28  8:00 ` Pekka Enberg
2006-11-28 18:05   ` Christoph Lameter
2006-11-28 19:07     ` Pekka J Enberg
2006-11-28 19:11       ` Christoph Lameter
2006-11-28 19:19         ` Pekka J Enberg
2006-11-28 19:24           ` Pekka Enberg
2006-11-28 19:27             ` Christoph Lameter
2006-11-28 19:25           ` Christoph Lameter
2006-11-28 19:32             ` Pekka Enberg
2006-11-28 19:53               ` Christoph Lameter
2006-11-29  0:30               ` Christoph Lameter
2006-11-29  7:08                 ` Pekka Enberg
2006-11-29 19:18                   ` Christoph Lameter
2006-11-29  8:26 ` Christoph Hellwig
2006-11-29  8:38   ` Nick Piggin
2006-11-29 19:24     ` Christoph Lameter
2006-11-30  1:58       ` Nick Piggin
2006-11-30  2:43         ` Christoph Lameter
2006-11-30  3:04           ` Nick Piggin
2006-11-30  3:39             ` Christoph Lameter
2006-11-30  3:44               ` Nick Piggin
2006-11-30  3:50                 ` Christoph Lameter
2006-11-30  4:18                   ` Nick Piggin [this message]
2006-11-30  4:28                     ` Christoph Lameter
2006-11-30  5:01                       ` Nick Piggin
2006-11-30  7:12         ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=456E5B9C.6030504@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=akpm@osdl.org \
    --cc=clameter@sgi.com \
    --cc=hch@infradead.org \
    --cc=linux-mm@kvack.org \
    --cc=manfred@colorfullife.com \
    --cc=mpm@selenic.com \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.