From: Jeff Garzik <jgarzik@pobox.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: torvalds@osdl.org, Michael Buesch <mb@bu3sch.de>,
netdev@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] r8169: Fix iteration variable sign
Date: Thu, 30 Nov 2006 06:20:39 -0500 [thread overview]
Message-ID: <456EBE87.1070806@pobox.com> (raw)
In-Reply-To: <20061129212133.GB18057@electric-eye.fr.zoreil.com>
Francois Romieu wrote:
> This changes the type of variable "i" in rtl8169_init_one()
> from "unsigned int" to "int". "i" is checked for < 0 later,
> which can never happen for "unsigned". This results in broken
> error handling.
>
> Signed-off-by: Michael Buesch <mb@bu3sch.de>
> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
ACK but doesn't seem to apply to 2.6.19?
should this go into #upstream rather than #upstream-fixes?
next prev parent reply other threads:[~2006-11-30 11:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-29 19:48 [PATCH] r8169: Fix iteration variable sign Michael Buesch
2006-11-29 21:21 ` Francois Romieu
2006-11-30 11:20 ` Jeff Garzik [this message]
2006-11-30 14:14 ` Michael Buesch
2006-11-30 18:56 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=456EBE87.1070806@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.