All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] winbond IDE depends on IDEDMA
Date: Thu, 30 Nov 2006 21:25:58 +0300	[thread overview]
Message-ID: <456F2236.3030401@ru.mvista.com> (raw)
In-Reply-To: <20061130143803.GA22451@aepfle.de>

Hello.

Olaf Hering wrote:
> winbond ide depends on idedma.

[...]

> Index: linux-2.6.19/drivers/ide/Kconfig
> ===================================================================
> --- linux-2.6.19.orig/drivers/ide/Kconfig
> +++ linux-2.6.19/drivers/ide/Kconfig
> @@ -391,7 +391,7 @@ config BLK_DEV_RZ1000
>  
>  config BLK_DEV_SL82C105
>  	tristate "Winbond SL82c105 support"
> -	depends on PCI && (PPC || ARM) && BLK_DEV_IDEPCI
> +	depends on PCI && (PPC || ARM) && BLK_DEV_IDEPCI && BLK_DEV_IDEDMA_PCI
>  	help
>  	  If you have a Winbond SL82c105 IDE controller, say Y here to enable
>  	  special configuration for this chip. This is common on various CHRP

    This whole item should be moved below, under ifdef BLK_DEV_IDEDMA_PCI 
then, for consistency.  Please recast.

WBR, Sergei

  parent reply	other threads:[~2006-11-30 18:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-30 14:39 [PATCH] winbond IDE depends on IDEDMA Olaf Hering
2006-11-30 17:26 ` Bartlomiej Zolnierkiewicz
2006-11-30 18:25 ` Sergei Shtylyov [this message]
2006-11-30 18:52 ` Olaf Hering
2006-11-30 19:27   ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=456F2236.3030401@ru.mvista.com \
    --to=sshtylyov@ru.mvista.com \
    --cc=akpm@osdl.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=olaf@aepfle.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.