From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: akpm@osdl.org, bzolnier@gmail.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH] (2.6.19-rc6-mm2) pdc202xx_new cleanup
Date: Fri, 01 Dec 2006 15:36:18 +0300 [thread overview]
Message-ID: <457021C2.3040703@ru.mvista.com> (raw)
In-Reply-To: <20061201001321.1b946f0e@localhost.localdomain>
Hello.
Alan wrote:
> I believe this is completely the wrong thing to do. Adding a ton of
> changes to the existing (and stable) life expired drivers/ide driver
> rather than keeping new and risky stuff in the new libata code is bad.
The new and risky stuff is long agon in there.
> The existing code *works*, its been rock solid since the reset drain fix
Don't make me laugh. pdc202xx_new certainly doesn't deserve these
compliments. It has known PLL problems even on x86 if you have more than 2
contorollers, and on non-x86 this turns into its complete inability to support
anything above UltraDMA/33.
> and it is the code everyone who is conservative relies on not to eat
> their data. We have somewhere to do new and cool stuff its libata.
I'm not interested in libata development currently, and interested in
fixing the age-old crap in drivers/ide/.
> I don't see the point in risking destabilising a good solid driver. I can
> just about see justification for !X86 implementation of the PLL handling
> but that is about it.
All in a good time.
> Alan
WBR, Sergei
next prev parent reply other threads:[~2006-12-01 12:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-30 18:51 [PATCH] (2.6.19-rc6-mm2) pdc202xx_new cleanup Sergei Shtylyov
2006-12-01 0:13 ` Alan
2006-12-01 12:36 ` Sergei Shtylyov [this message]
2006-12-01 13:05 ` Sergei Shtylyov
2006-12-02 15:40 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=457021C2.3040703@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.