From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jiri Slaby <jslaby-IBi9RG/b67k@public.gmane.org>,
kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Andrzej Hajda <a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE
Date: Tue, 09 Feb 2016 16:26:38 +0100 [thread overview]
Message-ID: <4571887.rTPndCnv20@wuerfel> (raw)
In-Reply-To: <1455030539-10798-1-git-send-email-linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
On Tuesday 09 February 2016 07:08:59 Guenter Roeck wrote:
> IS_ERR_VALUE() assumes that its parameter is an unsigned long.
> It can not be used to check if an unsigned int reflects an error.
> Doing so can result in the following build warning.
>
> drivers/tty/serial/digicolor-usart.c: In function ‘digicolor_uart_probe’:
> include/linux/err.h:21:38: warning:
> comparison is always false due to limited range of data type
> drivers/tty/serial/digicolor-usart.c:485:6: note:
> in expansion of macro ‘IS_ERR_VALUE’
>
> If that warning is seen, an error return from platform_get_irq() is missed.
>
>
The patch looks correct to me, but what compiler version and which kernel
tree is it that triggered the warning?
Andrzej Hajda just modified the definition of IS_ERR_VALUE(), and the
changes are still under discussion, but I don't see that warning with
any of the versions.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE
Date: Tue, 09 Feb 2016 16:26:38 +0100 [thread overview]
Message-ID: <4571887.rTPndCnv20@wuerfel> (raw)
In-Reply-To: <1455030539-10798-1-git-send-email-linux@roeck-us.net>
On Tuesday 09 February 2016 07:08:59 Guenter Roeck wrote:
> IS_ERR_VALUE() assumes that its parameter is an unsigned long.
> It can not be used to check if an unsigned int reflects an error.
> Doing so can result in the following build warning.
>
> drivers/tty/serial/digicolor-usart.c: In function ?digicolor_uart_probe?:
> include/linux/err.h:21:38: warning:
> comparison is always false due to limited range of data type
> drivers/tty/serial/digicolor-usart.c:485:6: note:
> in expansion of macro ?IS_ERR_VALUE?
>
> If that warning is seen, an error return from platform_get_irq() is missed.
>
>
The patch looks correct to me, but what compiler version and which kernel
tree is it that triggered the warning?
Andrzej Hajda just modified the definition of IS_ERR_VALUE(), and the
changes are still under discussion, but I don't see that warning with
any of the versions.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Guenter Roeck <linux@roeck-us.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Baruch Siach <baruch@tkos.co.il>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Jiri Slaby <jslaby@suse.com>,
kernel-testers@vger.kernel.org,
Andrzej Hajda <a.hajda@samsung.com>
Subject: Re: [PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE
Date: Tue, 09 Feb 2016 16:26:38 +0100 [thread overview]
Message-ID: <4571887.rTPndCnv20@wuerfel> (raw)
In-Reply-To: <1455030539-10798-1-git-send-email-linux@roeck-us.net>
On Tuesday 09 February 2016 07:08:59 Guenter Roeck wrote:
> IS_ERR_VALUE() assumes that its parameter is an unsigned long.
> It can not be used to check if an unsigned int reflects an error.
> Doing so can result in the following build warning.
>
> drivers/tty/serial/digicolor-usart.c: In function ‘digicolor_uart_probe’:
> include/linux/err.h:21:38: warning:
> comparison is always false due to limited range of data type
> drivers/tty/serial/digicolor-usart.c:485:6: note:
> in expansion of macro ‘IS_ERR_VALUE’
>
> If that warning is seen, an error return from platform_get_irq() is missed.
>
>
The patch looks correct to me, but what compiler version and which kernel
tree is it that triggered the warning?
Andrzej Hajda just modified the definition of IS_ERR_VALUE(), and the
changes are still under discussion, but I don't see that warning with
any of the versions.
Arnd
next prev parent reply other threads:[~2016-02-09 15:26 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 15:08 [PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE Guenter Roeck
2016-02-09 15:08 ` Guenter Roeck
[not found] ` <1455030539-10798-1-git-send-email-linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2016-02-09 15:26 ` Arnd Bergmann [this message]
2016-02-09 15:26 ` Arnd Bergmann
2016-02-09 15:26 ` Arnd Bergmann
2016-02-10 2:37 ` Guenter Roeck
2016-02-10 2:37 ` Guenter Roeck
2016-02-10 2:37 ` Guenter Roeck
[not found] ` <56BAA27A.9050605-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2016-02-10 15:21 ` Arnd Bergmann
2016-02-10 15:21 ` Arnd Bergmann
2016-02-10 15:21 ` Arnd Bergmann
2016-02-11 3:38 ` Guenter Roeck
2016-02-11 3:38 ` Guenter Roeck
2016-02-11 3:38 ` Guenter Roeck
[not found] ` <56BC022B.7030004-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2016-02-11 6:45 ` Andrzej Hajda
2016-02-11 6:45 ` Andrzej Hajda
2016-02-11 6:45 ` Andrzej Hajda
[not found] ` <56BC2DF7.20803-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-02-11 15:32 ` Guenter Roeck
2016-02-11 15:32 ` Guenter Roeck
2016-02-11 15:32 ` Guenter Roeck
2016-02-12 6:38 ` Andrzej Hajda
2016-02-12 6:38 ` Andrzej Hajda
2016-02-11 10:46 ` Russell King - ARM Linux
2016-02-11 10:46 ` Russell King - ARM Linux
2016-02-11 10:46 ` Russell King - ARM Linux
2016-02-11 15:13 ` Guenter Roeck
2016-02-11 15:13 ` Guenter Roeck
2016-02-11 6:50 ` Baruch Siach
2016-02-11 6:50 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4571887.rTPndCnv20@wuerfel \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=jslaby-IBi9RG/b67k@public.gmane.org \
--cc=kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.