Re: [PATCH 0/2] mountd: clean up rmtab handling

[Jeff Layton <jlayton@poochiereds.net>]

Neil Brown wrote:
> 
> I'm not convinced... I don't like the idea of mapping an IP address to
> a hostname and then just working with the hostname.  Because it is
> really IP addresses that you trust, not host names (in the case of
> multi-homed hosts particularly).
> 

The patch I posted doesn't do that though. Perhaps I didn't explain it 
well enough...

All that patch does is get rid of the caching of the hostname list in 
my_client. Currently, what happens is that we build a comma separated 
list of "hostnames" and stuff that into my_client.m_hostname. We build 
this comma-separated list via client_compose, which just calls 
client_check repeatedly to see what hostnames this address matches.

The patch I posted still uses the exact same decision making process to 
see if an address matches an nfs_client entry (client_check). It just no 
longer does this in two stages via the comma-separated list.

The patch I posted should make no change in behavior of whether a host 
is allowed or denied, aside from the particular case that we already 
discussed where a cached my_client hostname list is no longer correct.

All that said, I'm OK with pulling this info out of the kernel caches 
instead. I'll have a look over the latest patch that you sent and see if 
it does what we need.

Thanks,
Jeff

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs