From: Zach Brown <zach.brown@oracle.com>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch] kill pointless ki_nbytes assignment in aio_setup_single_vector
Date: Mon, 04 Dec 2006 12:22:32 -0800 [thread overview]
Message-ID: <45748388.9030400@oracle.com> (raw)
In-Reply-To: <000101c717c2$0fe26ce0$2589030a@amr.corp.intel.com>
Chen, Kenneth W wrote:
> io_submit_one assigns ki_left = ki_nbytes = iocb->aio_nbytes, then
> calls down to aio_setup_iocb, then to aio_setup_single_vector. In there,
> ki_nbytes is reassigned to the same value it got two call stack above it.
> There is no need to do so.
>
> Signed-off-by: Ken Chen <kenneth.w.chen@intel.com>
That seems to be the case, indeed.
Acked-by: Zach Brown <zach.brown@oracle.com>
- z
prev parent reply other threads:[~2006-12-04 20:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-04 16:34 [patch] kill pointless ki_nbytes assignment in aio_setup_single_vector Chen, Kenneth W
2006-12-04 20:22 ` Zach Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45748388.9030400@oracle.com \
--to=zach.brown@oracle.com \
--cc=akpm@osdl.org \
--cc=kenneth.w.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.