Re: [PATCH] cleanup write to argument array hack

[Josh Triplett <josh@freedesktop.org>]

[-- Attachment #1: Type: text/plain, Size: 924 bytes --]

Christopher Li wrote:
> The sparse interface is a kind of snaky that it change the input argument
> array. The function sparse() does the same hack just to skip the files.
> 
> This patch add the ptr list for string. So sparse_initialize will
> return list of file to compile. The string pointer is not aligned
> at word boundary. This patch introduce non taged version of the ptr
> list iteration function.

Nice improvement; thanks.

Since tagged lists seem like by far the common case, I'd prefer to see
PTR_ENTRY keep its current name, as you did with add_ptr_list.  Also, your
patch didn't update test-unssa.c.  I've merged your patch, with those two
additional changes.

I'd also love to see some additional static type checking here, to prevent
using the untagged functions on a tagged list or vice versa at compile time,
rather than allowing mysterious corruption at runtime.

- Josh Triplett


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]