From: Gerd Hoffmann <kraxel@suse.de>
To: Magnus Damm <magnus@valinux.co.jp>
Cc: Xen devel list <xen-devel@lists.xensource.com>
Subject: kexec trouble
Date: Tue, 05 Dec 2006 15:37:27 +0100 [thread overview]
Message-ID: <45758427.9010803@suse.de> (raw)
Hi,
Uh, it's a bit messy, with the changes sprinkled over the sparse tree
and the patches directory, which makes it a bit hard to fixup stuff.
IMHO the kexec code makes way to many decisions at compile time, not
runtime, especially the ones in the kexec code core. Having something
depend on CONFIG_XEN doesn't fly with the paravirt approach planned for
mainline merge (same kernel binary runs both native and paravirtualized).
I'm also in trouble now with guest kexec patches as they work with guest
phys addrs not machine phys addrs.
I think we need either wrapper functions for machine_kexec_* functions
which dispatch to the correct function depending on the environment
(dom0 vs domU, later also native) or just make them function pointers to
archive the same effect. Same goes for the KEXEC_ARCH_HAS_PAGE_MACROS
stuff. IMHO "#ifdef CONFIG_XEN" should go away from the core code (i.e.
kernel/kexec.c).
cheers,
Gerd
--
Gerd Hoffmann <kraxel@suse.de>
next reply other threads:[~2006-12-05 14:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-05 14:37 Gerd Hoffmann [this message]
2006-12-05 15:53 ` kexec trouble Magnus Damm
2006-12-05 16:55 ` Gerd Hoffmann
2006-12-06 4:08 ` Magnus Damm
2006-12-06 8:48 ` Gerd Hoffmann
2006-12-06 9:41 ` Magnus Damm
2006-12-06 10:31 ` Gerd Hoffmann
2006-12-06 11:11 ` Magnus Damm
2006-12-06 13:23 ` Gerd Hoffmann
2006-12-06 13:40 ` Muli Ben-Yehuda
2006-12-07 11:24 ` Gerd Hoffmann
2006-12-08 4:15 ` Magnus Damm
2006-12-08 10:01 ` Gerd Hoffmann
2006-12-08 10:24 ` Ian Campbell
2006-12-08 11:28 ` Gerd Hoffmann
2006-12-08 11:32 ` Keir Fraser
2006-12-08 11:52 ` Ian Campbell
2006-12-08 15:49 ` Ian Campbell
2006-12-06 8:37 ` Keir Fraser
2006-12-06 9:08 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45758427.9010803@suse.de \
--to=kraxel@suse.de \
--cc=magnus@valinux.co.jp \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.