From: Patrick McHardy <kaber@trash.net>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: "David S. Miller" <davem@davemloft.net>,
netfilter-devel@lists.netfilter.org, netdev@vger.kernel.org
Subject: Re: [PATCH] allow ip_tables.h to be used from userspace
Date: Tue, 05 Dec 2006 19:38:21 +0100 [thread overview]
Message-ID: <4575BC9D.8070900@trash.net> (raw)
In-Reply-To: <20061205102927.4f1ef22f@freekitty>
Stephen Hemminger wrote:
> The xtables version of ip_tables.h was no longer usable (in sanitized form)
> by iproute2 and other applications because sparse annotations had crept
> in.
>
> @@ -194,7 +194,7 @@ struct ipt_replace
> /* Number of counters (must be equal to current number of entries). */
> unsigned int num_counters;
> /* The old entries' counters. */
> - struct xt_counters __user *counters;
> + struct xt_counters *counters;
# Eliminate the contents of (and inclusions of) compiler.h
HDRSED := sed -e "s/ inline / __inline__ /g" \
-e "s/[[:space:]]__user[[:space:]]\+/ /g" \
-e "s/(__user[[:space:]]\+/ (/g" \
I think this regex should be fixed instead to get rid of it
while sanitizing (Makefile.headersinst).
next prev parent reply other threads:[~2006-12-05 18:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-05 18:29 [PATCH] allow ip_tables.h to be used from userspace Stephen Hemminger
2006-12-05 18:38 ` Patrick McHardy [this message]
2006-12-05 18:46 ` Stephen Hemminger
2006-12-05 18:52 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4575BC9D.8070900@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.