All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: "Toralf Förster" <toralf.foerster@gmx.de>
Cc: coreteam@netfilter.org, netfilter@lists.netfilter.org
Subject: Re: [netfilter-core] linux-2.6.19-ge6243863 build #160 failed
Date: Wed, 06 Dec 2006 09:34:47 +0100	[thread overview]
Message-ID: <457680A7.4080803@trash.net> (raw)
In-Reply-To: <200612051617.24705.toralf.foerster@gmx.de>

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

Toralf Förster wrote:
> Hello,
> 
> the build with the attached .config failed, make ends with:
> ...
> WARNING: "ip_route_output_key" [net/netfilter/nf_conntrack_h323.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
> 
> Here's the config:
> 
> # CONFIG_INET is not set

> CONFIG_NF_CONNTRACK=y

Interesting combination :) I assume you used make randconfig and don't
really have a reason for enabling conntrack without INET ..

The easiest fix seems to be to let everything under net/netfilter depend
on INET.


[-- Attachment #2: x --]
[-- Type: text/plain, Size: 1108 bytes --]

[NETFILTER]: Fix INET=n linking error

Building with INET=n results in

WARNING: "ip_route_output_key" [net/netfilter/nf_conntrack_h323.ko] undefined!

The entire code in net/netfilter is only used for IPv4/IPv6 currently, so
let it depend on INET.

Noticed by Toralf Förster <toralf.foerster@gmx.de>.

Signed-off-by: Patrick McHardy <kaber@trash.net>

---
commit ce95407aa64e1add96db823d0020f68a5941eb9a
tree 44f0eb5164ee3b0029c6da1aa97fd9517bfb2291
parent fe1a4d3f910960f27afaa4e5d10050cf8d2460c6
author Patrick McHardy <kaber@trash.net> Wed, 06 Dec 2006 09:32:05 +0100
committer Patrick McHardy <kaber@trash.net> Wed, 06 Dec 2006 09:32:42 +0100

 net/netfilter/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
index 3a66878..1b853c3 100644
--- a/net/netfilter/Kconfig
+++ b/net/netfilter/Kconfig
@@ -1,5 +1,5 @@
 menu "Core Netfilter Configuration"
-	depends on NET && NETFILTER
+	depends on NET && INET && NETFILTER
 
 config NETFILTER_NETLINK
        tristate "Netfilter netlink interface"

           reply	other threads:[~2006-12-06  8:34 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <200612051617.24705.toralf.foerster@gmx.de>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=457680A7.4080803@trash.net \
    --to=kaber@trash.net \
    --cc=coreteam@netfilter.org \
    --cc=netfilter@lists.netfilter.org \
    --cc=toralf.foerster@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.