From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: Example(Load_balancer) Tx Flush Bug(This bug DPDK each version) Date: Wed, 21 Dec 2016 16:08:47 +0100 Message-ID: <4577901.1XJahbXBcx@xps13> References: <2016122121181642100644@raisecom.com> <2016122121292174988745@raisecom.com> <2016122122394164225248@raisecom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, =?utf-8?B?5p2O6Z2e?= , =?utf-8?B?5pa95bGV?= To: Maple Return-path: Received: from mail-wj0-f180.google.com (mail-wj0-f180.google.com [209.85.210.180]) by dpdk.org (Postfix) with ESMTP id 3FFA110C4D for ; Wed, 21 Dec 2016 16:08:49 +0100 (CET) Received: by mail-wj0-f180.google.com with SMTP id tk12so206144699wjb.3 for ; Wed, 21 Dec 2016 07:08:49 -0800 (PST) In-Reply-To: <2016122122394164225248@raisecom.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Thanks for trying to send a patch. Below are some comments to help you sending a proper patch. 2016-12-21 22:39, Maple: > From 94f2eaed51e6e5402e8c03b80e0999a4fd420390 Mon Sep 17 00:00:00 2001 > From: root Here we should have your real name, not "root". > To: > Cc: , , > Date: Wed, 21 Dec 2016 22:31:29 +0800 > Subject: [PATCH] load_balancer Tx Flush Bug > > We found a bug in use load_balancer example,and,This bug DPDK each version. > In IO tx flush, only flush port 0. > So,If I enable more than the Port,then,In addition to 0 port won't flush. > > Signed-off-by: root Here alse we should have your real name. See ~/.gitconfig > --- > a/examples/load_balancer/runtime.c | 667 ++++++++++++++++++++++++++++++++++++ > b/examples/load_balancer/runtime.c | 669 +++++++++++++++++++++++++++++++++++++ You are sending the whole file instead of the diff. Are you using git? It should be as simple as "git clone git://dpdk.org/dpdk", then modify the file, then "git commit -as", then send patch with "git send-email -1 --to dev@dpdk.org". As it will be your second version, you should add these options: -v2 --in-reply-to '<2016122122394164225248@raisecom.com>' Thanks