From: Jeff Garzik <jgarzik@pobox.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: "Amit S. Kale" <amitkale@netxen.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] netxen: sparse warning and ioctl bug fixes
Date: Thu, 07 Dec 2006 05:00:11 -0500 [thread overview]
Message-ID: <4577E62B.2080704@pobox.com> (raw)
In-Reply-To: <20061205120717.2e362ddf@freekitty>
Stephen Hemminger wrote:
> Fix sparse warnings and get rid of casts that hide misuse
> of __user pointers. There were two real bugs here:
> * ioctl was copying uninitialized stack om NETXEN_NIC_NAME
> * ioctl was dereferencing a user pointer
> in nettxen_nic_cmd_clear_stats.
>
> IMHO the ioctl usage in this driver is going to be more maintenance
> burden than useful. and should be removed.
>
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
ACK but netxen is in heavy flux right now, with upstream workqueue
changes, changes from Amit, etc. so, it didn't apply.
Ever considered submitting via git? :)
Jeff
next prev parent reply other threads:[~2006-12-07 10:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-05 20:07 [PATCH] netxen: sparse warning and ioctl bug fixes Stephen Hemminger
2006-12-06 16:10 ` Amit S. Kale
2006-12-06 16:30 ` Stephen Hemminger
2006-12-07 10:00 ` Jeff Garzik [this message]
2006-12-07 10:09 ` Christoph Hellwig
2006-12-15 15:57 ` [PATCH] netxen: remove private ioctl Stephen Hemminger
2006-12-15 16:04 ` Christoph Hellwig
2006-12-27 5:36 ` Amit S. Kale
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4577E62B.2080704@pobox.com \
--to=jgarzik@pobox.com \
--cc=amitkale@netxen.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.