From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: BUG: make O= broken Date: Thu, 07 Dec 2006 12:18:50 +0100 Message-ID: <4577F89A.7090903@suse.de> References: <4577EAA3.30609@suse.de> <1165487554.9694.140.camel@localhost.localdomain> <4577F450.6010804@suse.de> <1165489726.9694.148.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1165489726.9694.148.camel@localhost.localdomain> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: Xen devel list List-Id: xen-devel@lists.xenproject.org Ian Campbell wrote: > On Thu, 2006-12-07 at 12:00 +0100, Gerd Hoffmann wrote: >> I've tried to turn the sparse tree into a big patch (is there an easy >> way to do this btw?). > > make linux-2.6-xen.patch should give you a patch against the upstream > kernel, is that what you are looking for? I needed a patch against the ref tree, not the pristine tree. It should come close though, I'll have a look. >> Documentation/dontdiff excludes too much giving >> me a incomplete xenlinux tree, which in turn generated build errors >> looking much like it takes the wrong (native) include files. I've seen >> that in the past with O=, so I blamed it first ... > > That's strange -- I wouldn't expect the sparse tree to add anything > which would be listed in dontdiff. Are the symlinks into the sparse tree > confusing diff perhaps? No. Fixed up dontdiff, now it works, at least as long as I do the "prep" step only. Offending entries: asm-offset.c (which is a bug IMHO). asm (probably to catch include/asm symlink, but catches include/asm-{arch}/mach-xen/asm too). version.h (guess for the generated include/linux/version.h, but catches include/xen/interface/version.h too). cheers, Gerd -- Gerd Hoffmann