All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerry Van Baren <gerald.vanbaren@smiths-aerospace.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] 83xx: Put the version (and magic) after the HRCW.
Date: Thu, 07 Dec 2006 08:22:39 -0500	[thread overview]
Message-ID: <4578159F.9050509@smiths-aerospace.com> (raw)
In-Reply-To: <F6AD7E21CDF4E145A44F61F43EE6D939B5054C@tmnt04.transmode.se>

Joakim Tjernlund wrote:
>> Sam Song wrote:
>>> Jerry Van Baren <gerald.vanbaren@comcast.net> wrote:
>>>> Put the version (and magic) after the HRCW.  This
>>>> puts it in a fixed location in flash, not at the
>>> start 
>>>> of flash but as close as we can get.
>>> Nice effort. Space saving and better version check.
>>>
>>> I guess the same change could apply for MPC8260/47/8.
>>>
>>> Thanks,
>>>
>>> Sam
>> Yes.  Most boards have the version in the first bytes of 
>> flash, but this
>> was not possible on the 82xx because of the HRCW, so it was put in
>> .data.  This set up was copied for the 83xx (which also has a 
>> HRCW).  My
>> change moves it back to .text just after the HRCW.  I put also the
>> u-boot magic number back in in honor of Wolfgang. ;-)
>>
>> If you change the file names in the patch, it probably would 
>> apply.  :-)
>>  I intend to do this (perhaps literally), but ran out of 
>> ambition tonight.
>>
> 
> Looks almost the same as the patch I sent the other day. I am good
> with either version.
> 
>  Jocke

Hi Jocke,

Yes, your patch, and my objection to its removal of the HRCW, was the 
genesis of this one.  The two differences are (a) I kept the HRCW and 
(b) I put the "u-boot magic number" in (no known reason to do this, but 
it Just Seemed Right[tm]).  The result of (b) is that the version starts 
at flash offset 0x44 rather than 0x40.  Should be NBD.

Thanks,
gvb

  reply	other threads:[~2006-12-07 13:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-07  8:32 [U-Boot-Users] [PATCH] 83xx: Put the version (and magic) after the HRCW Joakim Tjernlund
2006-12-07 13:22 ` Jerry Van Baren [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-12-07 17:05 Joakim Tjernlund
2006-12-07  3:16 [U-Boot-Users] Re: " Sam Song
2006-12-07  3:45 ` [U-Boot-Users] " Jerry Van Baren
2006-12-08  2:49   ` Jerry Van Baren
2006-12-08 16:33     ` Timur Tabi
2006-12-08 16:50       ` Jerry Van Baren
2006-12-08 21:13         ` Timur Tabi
2006-12-08 21:36           ` Jerry Van Baren
2006-12-08 21:38             ` Timur Tabi
2006-12-07  2:23 Jerry Van Baren
2006-12-07  2:55 ` Jerry Van Baren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4578159F.9050509@smiths-aerospace.com \
    --to=gerald.vanbaren@smiths-aerospace.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.