From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] possible ELDK4 gcc compiler bug
Date: Thu, 07 Dec 2006 11:25:16 -0600 [thread overview]
Message-ID: <45784E7C.5040704@freescale.com> (raw)
In-Reply-To: <200612071812.39035.matthias.fuchs@esd-electronics.com>
Matthias Fuchs wrote:
>
> Do so with accessors result in code like this (still missing some casts):
>
> out32(&(fpga->fifo[i].ctrl), in32(&(fpga->fifo[i].ctrl)) | 0x8000);
>
> Is this really recommended?
That's how I would do it. You could use a temporary variable:
u32 ctrl;
ctrl = in32(&(fpga->fifo[i].ctrl));
out32(&(fpga->fifo[i].ctrl), ctrl | 0x8000);
--
Timur Tabi
Linux Kernel Developer @ Freescale
next prev parent reply other threads:[~2006-12-07 17:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-07 16:21 [U-Boot-Users] possible ELDK4 gcc compiler bug Matthias Fuchs
2006-12-07 16:28 ` Matthias Fuchs
2006-12-07 16:38 ` Pantelis Antoniou
2006-12-07 17:12 ` Matthias Fuchs
2006-12-07 17:25 ` Timur Tabi [this message]
2006-12-07 17:33 ` Pantelis Antoniou
2006-12-07 16:42 ` Rune Torgersen
2006-12-07 16:55 ` Matthias Fuchs
2006-12-07 16:29 ` Pantelis Antoniou
2006-12-07 16:42 ` Tolunay Orkun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45784E7C.5040704@freescale.com \
--to=timur@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.