Re: [PATCH 05/15] kconfig: introduce domain builder config option

[Jason Andryuk <jason.andryuk@amd.com>]

On 2024-11-23 13:20, Daniel P. Smith wrote:
> Hyperlaunch domain builder will be the consolidated boot time domain building
> logic framework. Introduces the config option to enable this domain builder to
> and turn on the ability to load the domain configuration via a flattened device

"to and"?

> tree.

Maybe:
"Hyperlaunch is the boot time domain building framework where domain 
configuration is loaded via a flattened device tree.  Introduce a 
kconfig variable to control the feature."

> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>

> diff --git a/xen/arch/x86/domain_builder/Kconfig b/xen/arch/x86/domain_builder/Kconfig
> new file mode 100644
> index 000000000000..7be2ec3ed00f
> --- /dev/null
> +++ b/xen/arch/x86/domain_builder/Kconfig
> @@ -0,0 +1,15 @@
> +
> +menu "Domain Builder Features"
> +
> +config DOMAIN_BUILDER
> +	bool "Domain builder (UNSUPPORTED)" if UNSUPPORTED
> +	select LIB_DEVICE_TREE
> +	help
> +      Enables the domain builder capability to configure boot domain

Indent is off.

> +	  construction using a flattened device tree.
> +
> +	  This feature is currently experimental.

Does this need to be unsupported and experimental?  What makes this more 
experimental and/or unsupported than any other new feature?

At least with the commit message and indent fixes:

Reviewed-by: Jason Andryuk <jason.andryuk@amd.com>

> +
> +	  If unsure, say N.
> +
> +endmenu