Re: [Xenomai-core] [BUG] module usage counter of xenomai native corrupted (version 2.2.0 and 2.2.5)

[Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>]

Jan Kiszka wrote:
> Gilles Chanteperdrix wrote:
>>Index: ksrc/nucleus/shadow.c
>>===================================================================
>>--- ksrc/nucleus/shadow.c	(révision 1930)
>>+++ ksrc/nucleus/shadow.c	(copie de travail)
>>@@ -888,6 +888,9 @@
>> 
>> 	p = xnthread_archtcb(thread)->user_task;	/* May be != current */
>> 
>>+	if (!xnshadow_thrptd(p))
>>+		return;
>>+
>> 	magic = xnthread_get_magic(thread);
>> 
>> 	for (muxid = 0; muxid < XENOMAI_MUX_NR; muxid++) {
>>@@ -1639,8 +1642,6 @@
>> 		xnshadow_relax(0);
>> 
>> 	xnlock_get_irqsave(&nklock, s);
>>-	/* Prevent wakeup call from xnshadow_unmap(). */
>>-	xnshadow_thrptd(p) = NULL;
>> 	xnthread_archtcb(thread)->user_task = NULL;
>> 	/* xnpod_delete_thread() -> hook -> xnshadow_unmap(). */
>> 	xnpod_delete_thread(thread);
> 
> 
> Can't comment on the correctness of the second hunk, but it
> unfortunately doesn't change the situation that test case does not
> longer terminate with the first hunk applied. May look like a trivial
> issue - but it isn't. :->
> 

Indeed. And xnshadow_thrptd(current) == NULL is used by xnpod_schedule,
so the patch is probably completely incorrect.

-- 
                                                 Gilles Chanteperdrix