From: Linda Xie <lxiep@us.ibm.com>
To: linux-scsi@vger.kernel.org, James.Bottomley@SteelEye.com
Cc: Dave C Boutcher <sleddog@us.ibm.com>, Santiago Leon <santil@us.ibm.com>
Subject: [PATCH] imbvscsi: use 4k buffer to transfer config data
Date: Fri, 08 Dec 2006 20:51:37 -0600 [thread overview]
Message-ID: <457A24B9.2010804@us.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 245 bytes --]
Hi James,
This patch changes the size of the buffer used for transfering config
data to 4K. It was tested against
2.6.19-rc2 tree.
Please consider it for inclusion in upstream.
Thanks,
Linda Xie
IBM LTC
Signed-off-by: lxie@us.ibm.com
[-- Attachment #2: ibmvscsi_config.patch --]
[-- Type: text/plain, Size: 2260 bytes --]
--- linux-2.6.17.ppc64/drivers/scsi/ibmvscsi/ibmvscsi.c 2006-09-28 15:03:54.000000000 -0500
+++ linux-2.6.17.ppc64-linda/drivers/scsi/ibmvscsi/ibmvscsi.c 2006-09-28 15:00:56.000000000 -0500
@@ -86,8 +86,10 @@ static int max_id = 64;
static int max_channel = 3;
static int init_timeout = 5;
static int max_requests = 50;
+/* host data buffer size */
+#define buff_size 4096
-#define IBMVSCSI_VERSION "1.5.8"
+#define IBMVSCSI_VERSION "1.5.9"
MODULE_DESCRIPTION("IBM Virtual SCSI");
MODULE_AUTHOR("Dave Boutcher");
@@ -1347,7 +1349,7 @@ static ssize_t show_host_srp_version(str
(struct ibmvscsi_host_data *)shost->hostdata;
int len;
- len = snprintf(buf, PAGE_SIZE, "%s\n",
+ len = snprintf(buf, buff_size, "%s\n",
hostdata->madapter_info.srp_version);
return len;
}
@@ -1368,7 +1370,7 @@ static ssize_t show_host_partition_name(
(struct ibmvscsi_host_data *)shost->hostdata;
int len;
- len = snprintf(buf, PAGE_SIZE, "%s\n",
+ len = snprintf(buf, buff_size, "%s\n",
hostdata->madapter_info.partition_name);
return len;
}
@@ -1389,7 +1391,7 @@ static ssize_t show_host_partition_numbe
(struct ibmvscsi_host_data *)shost->hostdata;
int len;
- len = snprintf(buf, PAGE_SIZE, "%d\n",
+ len = snprintf(buf, buff_size, "%d\n",
hostdata->madapter_info.partition_number);
return len;
}
@@ -1409,7 +1411,7 @@ static ssize_t show_host_mad_version(str
(struct ibmvscsi_host_data *)shost->hostdata;
int len;
- len = snprintf(buf, PAGE_SIZE, "%d\n",
+ len = snprintf(buf, buff_size, "%d\n",
hostdata->madapter_info.mad_version);
return len;
}
@@ -1429,7 +1431,7 @@ static ssize_t show_host_os_type(struct
(struct ibmvscsi_host_data *)shost->hostdata;
int len;
- len = snprintf(buf, PAGE_SIZE, "%d\n", hostdata->madapter_info.os_type);
+ len = snprintf(buf, buff_size, "%d\n", hostdata->madapter_info.os_type);
return len;
}
@@ -1448,7 +1450,7 @@ static ssize_t show_host_config(struct c
(struct ibmvscsi_host_data *)shost->hostdata;
/* returns null-terminated host config data */
- if (ibmvscsi_do_host_config(hostdata, buf, PAGE_SIZE) == 0)
+ if (ibmvscsi_do_host_config(hostdata, buf, buff_size) == 0)
return strlen(buf);
else
return 0;
next reply other threads:[~2006-12-08 23:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-09 2:51 Linda Xie [this message]
2006-12-09 0:14 ` [PATCH] imbvscsi: use 4k buffer to transfer config data Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=457A24B9.2010804@us.ibm.com \
--to=lxiep@us.ibm.com \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=santil@us.ibm.com \
--cc=sleddog@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.