From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Fehlig Subject: [PATCH] [xend] Host.get_resident_VMs RPC Date: Mon, 11 Dec 2006 13:08:44 -0700 Message-ID: <457DBACC.6000206@novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------070004080507000700050107" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Xen-devel List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --------------070004080507000700050107 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit I've noticed that Host.get_resident_VMs RPC returns duplicate references to running VMs. Is this the intent or a bug :-)? In XendDomain.py we have def get_domain_refs(self): result = [] try: self.domains_lock.acquire() result = [d.get_uuid() for d in self.domains.values()] result += self.managed_domains.keys() return result finally: self.domains_lock.release() and as you can see a running domain would be included twice in the resulting list. If this is a bug, patch attached. If intentional, please let me know so I can handle it appropriately in client code. Regards, Jim --------------070004080507000700050107 Content-Type: text/x-patch; name="libxen-residentVMs.patch" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="libxen-residentVMs.patch" IyBIRyBjaGFuZ2VzZXQgcGF0Y2gKIyBVc2VyIGpmZWhsaWdAamZlaGxpZzIucHJvdm8ubm92 ZWxsLmNvbQojIERhdGUgMTE2NTg2NzY0MCAyNTIwMAojIE5vZGUgSUQgNjg3ZTU3NmVlOTll YjY4ZDEwMzI0ZDAwMTNiZmQ5YWNjMzcyNDY4YwojIFBhcmVudCAgMzcxNDFjM2EzZDM5OTU2 YWQ1ZmFmMmQ0ZTJhOTEyNzZlYWNhNTU3YgpXaGVuIGVudW1lcmF0aW5nIFZNcyByZXNpZGVu dCBvbiBhIGhvc3QgKEhvc3QuZ2V0X3Jlc2lkZW50X1ZNcyBSUEMpLCBlbnN1cmUgVk1zIHdp dGggc2FtZSBVVUlEIG9ubHkgYXBwZWFyIG9uY2UgaW4gdGhlIGxpc3QuCgpTaWduZWQtb2Zm LWJ5OiBKaW0gRmVobGlnIDxqZmVobGlnQG5vdmVsbC5jb20+CgpkaWZmIC1yIDM3MTQxYzNh M2QzOSAtciA2ODdlNTc2ZWU5OWUgdG9vbHMvcHl0aG9uL3hlbi94ZW5kL1hlbmREb21haW4u cHkKLS0tIGEvdG9vbHMvcHl0aG9uL3hlbi94ZW5kL1hlbmREb21haW4ucHkJTW9uIERlYyAx MSAxNTowNjo1MyAyMDA2ICswMDAwCisrKyBiL3Rvb2xzL3B5dGhvbi94ZW4veGVuZC9YZW5k RG9tYWluLnB5CU1vbiBEZWMgMTEgMTM6MDc6MjAgMjAwNiAtMDcwMApAQCAtNTkxLDcgKzU5 MSw5IEBAIGNsYXNzIFhlbmREb21haW46CiAgICAgICAgIHRyeToKICAgICAgICAgICAgIHNl bGYuZG9tYWluc19sb2NrLmFjcXVpcmUoKQogICAgICAgICAgICAgcmVzdWx0ID0gW2QuZ2V0 X3V1aWQoKSBmb3IgZCBpbiBzZWxmLmRvbWFpbnMudmFsdWVzKCldCi0gICAgICAgICAgICBy ZXN1bHQgKz0gc2VsZi5tYW5hZ2VkX2RvbWFpbnMua2V5cygpCisgICAgICAgICAgICBmb3Ig ZCBpbiBzZWxmLm1hbmFnZWRfZG9tYWlucy5rZXlzKCk6CisgICAgICAgICAgICAgICAgaWYg ZCBub3QgaW4gcmVzdWx0OgorICAgICAgICAgICAgICAgICAgICByZXN1bHQuYXBwZW5kKGQp CiAgICAgICAgICAgICByZXR1cm4gcmVzdWx0CiAgICAgICAgIGZpbmFsbHk6CiAgICAgICAg ICAgICBzZWxmLmRvbWFpbnNfbG9jay5yZWxlYXNlKCkK --------------070004080507000700050107 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --------------070004080507000700050107--