From: Auke Kok <auke-jan.h.kok@intel.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Yan Burman <burman.yan@gmail.com>,
linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH 2.6.19] e1000: replace kmalloc with kzalloc
Date: Tue, 12 Dec 2006 10:32:46 -0800 [thread overview]
Message-ID: <457EF5CE.2030404@intel.com> (raw)
In-Reply-To: <84144f020612120934n612f513er606d2653f527eb67@mail.gmail.com>
Pekka Enberg wrote:
> On 12/12/06, Yan Burman <burman.yan@gmail.com> wrote:
>> size = txdr->count * sizeof(struct e1000_buffer);
>> - if (!(txdr->buffer_info = kmalloc(size, GFP_KERNEL))) {
>> + if (!(txdr->buffer_info = kzalloc(size, GFP_KERNEL))) {
>> ret_val = 1;
>> goto err_nomem;
>> }
>> - memset(txdr->buffer_info, 0, size);
>
> No one seems to be using size elsewhere so why not convert to
> kcalloc() and get rid of it? (Seems to apply to other places as well.)
I'll put it on my todo list.
Auke
next prev parent reply other threads:[~2006-12-12 18:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-12 16:53 [PATCH 2.6.19] e1000: replace kmalloc with kzalloc Yan Burman
2006-12-12 17:34 ` Pekka Enberg
2006-12-12 18:32 ` Auke Kok [this message]
2006-12-17 12:17 ` Ingo Oeser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=457EF5CE.2030404@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=burman.yan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.