From: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
To: lvm-devel@redhat.com
Subject: [PATCH LVM2] Guarantee ah->area_multiple non-zero
Date: Tue, 12 Dec 2006 17:53:58 -0500 [thread overview]
Message-ID: <457F3306.1070608@ce.jp.nec.com> (raw)
Hi,
This patch guarantees ah->area_multiple being non-zero.
Since ah->area_multiple is used everywhere to calculate the length
of allocation, it's safer to set 1 if ah->area_count is zero.
Otherwise, zero division could occur.
For example, ah->area_count can be zero when the allocation request
is only for log device.
It should be reproducible by converting corelog mirror to disklog
mirror. But fortunately or unfortunately, this bug is hidden by
other bug.
(See "[PATCH LVM2] set stripes = 0 for the log device only allocation")
Patch applicable to LVM2 2.02.16.
Thanks,
--
Jun'ichi Nomura, NEC Corporation of America
-------------- next part --------------
A non-text attachment was scrubbed...
Name: guarantee-area_multiple-non-zero.patch
Type: text/x-patch
Size: 1143 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20061212/3d8158be/attachment.bin>
reply other threads:[~2006-12-12 22:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=457F3306.1070608@ce.jp.nec.com \
--to=j-nomura@ce.jp.nec.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.