All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
To: lvm-devel@redhat.com
Subject: [PATCH LVM2] Detect allocation failure of log device
Date: Tue, 12 Dec 2006 17:54:54 -0500	[thread overview]
Message-ID: <457F333E.3010600@ce.jp.nec.com> (raw)

Hi,

This patch fixes the testing of allocation result
so that it doesn't miss the failure of log device allocation.


Current code only checks whether the number of extents for
normal devices are allocated as requested.
The number of extents allocated for the log device is out of
consideration.

As a result, the allocator returns success and the later operation
to the allocated extents will cause error with misleading error
messages like this:
  LV lv0_mlog: segment 1 has inconsistent PV area 0
  Internal error: LV segments corrupted in lv0_mlog.

We have to check for the case that only the allocation attempt for
the log device failed,


Patch applicable to LVM2 2.02.16.
Shell script to reproduce the problem and the sample metadata
is attached for reference.
You can reproduce the problem with just executing the script
without additional parameters.

Thanks,
-- 
Jun'ichi Nomura, NEC Corporation of America
-------------- next part --------------
A non-text attachment was scrubbed...
Name: detect-log-only-allocation-failure.patch
Type: text/x-patch
Size: 1056 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20061212/2f0f25b2/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lvm2-logonly-alloc-failure.sh
Type: application/x-sh
Size: 2323 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20061212/2f0f25b2/attachment.sh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: lvm2-logonly-alloc-failure.vg
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20061212/2f0f25b2/attachment.ksh>

                 reply	other threads:[~2006-12-12 22:54 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=457F333E.3010600@ce.jp.nec.com \
    --to=j-nomura@ce.jp.nec.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.