From: "yanjun.zhu" <yanjun.zhu@linux.dev>
To: Leon Romanovsky <leon@kernel.org>, Jason Gunthorpe <jgg@nvidia.com>
Cc: Leon Romanovsky <leonro@nvidia.com>,
Abhijit Gangurde <abhijit.gangurde@amd.com>,
Allen Hubbe <allen.hubbe@amd.com>,
Bart Van Assche <bvanassche@acm.org>,
Chengchang Tang <tangchengchang@huawei.com>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
Junxian Huang <huangjunxian6@hisilicon.com>,
Kalesh AP <kalesh-anakkur.purayil@broadcom.com>,
Konstantin Taranov <kotaranov@microsoft.com>,
linux-rdma@vger.kernel.org, Long Li <longli@microsoft.com>,
Michael Margolin <mrgolin@amazon.com>,
Mustafa Ismail <mustafa.ismail@intel.com>,
Potnuri Bharat Teja <bharat@chelsio.com>,
Selvin Xavier <selvin.xavier@broadcom.com>,
target-devel@vger.kernel.org,
Tatyana Nikolova <tatyana.e.nikolova@intel.com>,
Yishai Hadas <yishaih@nvidia.com>
Subject: Re: [PATCH rdma-next] RDMA: Use %pe format specifier for error pointers
Date: Thu, 18 Sep 2025 15:46:50 -0700 [thread overview]
Message-ID: <457e98bf-0fa7-4ff1-affe-400ac2e0ae72@linux.dev> (raw)
In-Reply-To: <e81ec02df1e474be20417fb62e779776e3f47a50.1758217936.git.leon@kernel.org>
On 9/18/25 10:53 AM, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> Convert error logging throughout the RDMA subsystem to use
> the %pe format specifier instead of PTR_ERR() with integer
> format specifiers.
We have already used this skill, and it has proven to be very useful.
With it, developers no longer need to look up error codes in err.h
Reviewed-by: Zhu Yanjun <yanjun.zhu@linux.dev>
>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> drivers/infiniband/core/agent.c | 3 +--
> drivers/infiniband/hw/bnxt_re/ib_verbs.c | 4 ++--
> drivers/infiniband/hw/bnxt_re/main.c | 3 +--
> drivers/infiniband/hw/cxgb4/device.c | 5 ++---
> drivers/infiniband/hw/efa/efa_com.c | 4 ++--
> drivers/infiniband/hw/efa/efa_verbs.c | 6 ++++--
> drivers/infiniband/hw/hfi1/device.c | 4 ++--
> drivers/infiniband/hw/hfi1/user_sdma.c | 4 ++--
> drivers/infiniband/hw/hns/hns_roce_mr.c | 8 ++++----
> drivers/infiniband/hw/ionic/ionic_admin.c | 18 +++++++++---------
> drivers/infiniband/hw/irdma/verbs.c | 6 +++---
> drivers/infiniband/hw/mana/main.c | 5 ++---
> drivers/infiniband/hw/mana/mr.c | 6 ++++--
> drivers/infiniband/hw/mlx4/mad.c | 8 ++++----
> drivers/infiniband/hw/mlx4/qp.c | 3 ++-
> drivers/infiniband/hw/mlx5/data_direct.c | 2 +-
> drivers/infiniband/hw/mlx5/gsi.c | 15 +++++++++------
> drivers/infiniband/hw/mlx5/main.c | 14 ++++++++++----
> drivers/infiniband/hw/mlx5/mr.c | 3 +--
> drivers/infiniband/ulp/srpt/ib_srpt.c | 16 +++++++---------
> 20 files changed, 72 insertions(+), 65 deletions(-)
>
next prev parent reply other threads:[~2025-09-18 22:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 17:53 [PATCH rdma-next] RDMA: Use %pe format specifier for error pointers Leon Romanovsky
2025-09-18 22:46 ` yanjun.zhu [this message]
2025-09-19 14:06 ` Dennis Dalessandro
2025-09-21 11:35 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=457e98bf-0fa7-4ff1-affe-400ac2e0ae72@linux.dev \
--to=yanjun.zhu@linux.dev \
--cc=abhijit.gangurde@amd.com \
--cc=allen.hubbe@amd.com \
--cc=bharat@chelsio.com \
--cc=bvanassche@acm.org \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=huangjunxian6@hisilicon.com \
--cc=jgg@nvidia.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=kotaranov@microsoft.com \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=mrgolin@amazon.com \
--cc=mustafa.ismail@intel.com \
--cc=selvin.xavier@broadcom.com \
--cc=tangchengchang@huawei.com \
--cc=target-devel@vger.kernel.org \
--cc=tatyana.e.nikolova@intel.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.