All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Vlad Lungu <vlad.lungu@windriver.com>,
	qemu-devel@nongnu.org, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH] multiboot: copy the cmdline verbatim
Date: Wed, 14 Dec 2016 17:32:09 -0500 (EST)	[thread overview]
Message-ID: <458039301.4070513.1481754729324.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20161214222601.GP3808@thinpad.lan.raisama.net>

> > > In other words: this fixes the mb_add_cmdline(kcmdline) case, and
> > > doesn't break comma escaping on the initrd case (because it was
> > > already broken). I don't see a problem with this patch.
> > 
> > ... there is one case of comma escaping that wasn't broken:
> > 
> >     $ qemu-system-x86_64 -kernel foo -initrd '/tmp/one
> >     arg,,with,,commas,/tmp/another arg,,with,,commas'
> > 
> 
> Oh, I didn't notice the whitespace-based split for initrd
> arguments.
> 
> This is messier than I thought. Maybe the simplest solution is to
> inline mb_add_cmdline() at both callers, and change the kcmdline
> one to use memcpy().

Yes, I agree.

Paolo

  reply	other threads:[~2016-12-14 22:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-14 16:19 [Qemu-devel] [PATCH] multiboot: copy the cmdline verbatim Vlad Lungu
2016-12-14 16:55 ` Paolo Bonzini
2016-12-14 17:00   ` Eduardo Habkost
2016-12-14 17:20     ` Paolo Bonzini
2016-12-14 17:51       ` Eduardo Habkost
2016-12-14 21:38         ` Paolo Bonzini
2016-12-14 22:26           ` Eduardo Habkost
2016-12-14 22:32             ` Paolo Bonzini [this message]
2016-12-15  9:44               ` Vlad Lungu
  -- strict thread matches above, loose matches on Subject: below --
2016-12-14 13:35 Vlad Lungu
2016-12-14 14:38 ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=458039301.4070513.1481754729324.JavaMail.zimbra@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=vlad.lungu@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.