From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] use vfs-defined file attribute flags
Date: Thu, 14 Dec 2006 12:21:36 -0600 [thread overview]
Message-ID: <45819630.3070701@sandeen.net> (raw)
In-Reply-To: <20061214181500.GA13856@infradead.org>
Christoph Hellwig wrote:
>> -#define LINUX_XFLAG_SYNC 0x00000008 /* Synchronous updates */
>> -#define LINUX_XFLAG_IMMUTABLE 0x00000010 /* Immutable file */
>> -#define LINUX_XFLAG_APPEND 0x00000020 /* writes to file may only append */
>> -#define LINUX_XFLAG_NODUMP 0x00000040 /* do not dump file */
>> -#define LINUX_XFLAG_NOATIME 0x00000080 /* do not update atime */
>> +#define LINUX_XFLAG_SYNC FS_SYNC_FL /* Synchronous updates */
>> +#define LINUX_XFLAG_IMMUTABLE FS_IMMUTABLE_FL /* Immutable file */
>> +#define LINUX_XFLAG_APPEND FS_APPEND_FL /* writes may only append */
>> +#define LINUX_XFLAG_NODUMP FS_NODUMP_FL /* do not dump file */
>> +#define LINUX_XFLAG_NOATIME FS_NOATIME_FL /* do not update atime */
>>
>
> Just kill the defines completly and use the FS_ flags
>
1 file changed, 5 insertions(+), 10 deletions(-)
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Index: linux-2.6.19/fs/xfs/linux-2.6/xfs_ioctl.c
===================================================================
--- linux-2.6.19.orig/fs/xfs/linux-2.6/xfs_ioctl.c
+++ linux-2.6.19/fs/xfs/linux-2.6/xfs_ioctl.c
@@ -1095,11 +1095,6 @@ xfs_ioc_fsgeometry(
/*
* Linux extended inode flags interface.
*/
-#define LINUX_XFLAG_SYNC 0x00000008 /* Synchronous updates */
-#define LINUX_XFLAG_IMMUTABLE 0x00000010 /* Immutable file */
-#define LINUX_XFLAG_APPEND 0x00000020 /* writes to file may only append */
-#define LINUX_XFLAG_NODUMP 0x00000040 /* do not dump file */
-#define LINUX_XFLAG_NOATIME 0x00000080 /* do not update atime */
STATIC unsigned int
xfs_merge_ioc_xflags(
@@ -1108,23 +1103,23 @@ xfs_merge_ioc_xflags(
{
unsigned int xflags = start;
- if (flags & LINUX_XFLAG_IMMUTABLE)
+ if (flags & FS_IMMUTABLE_FL)
xflags |= XFS_XFLAG_IMMUTABLE;
else
xflags &= ~XFS_XFLAG_IMMUTABLE;
- if (flags & LINUX_XFLAG_APPEND)
+ if (flags & FS_APPEND_FL)
xflags |= XFS_XFLAG_APPEND;
else
xflags &= ~XFS_XFLAG_APPEND;
- if (flags & LINUX_XFLAG_SYNC)
+ if (flags & FS_SYNC_FL)
xflags |= XFS_XFLAG_SYNC;
else
xflags &= ~XFS_XFLAG_SYNC;
- if (flags & LINUX_XFLAG_NOATIME)
+ if (flags & FS_NOATIME_FL)
xflags |= XFS_XFLAG_NOATIME;
else
xflags &= ~XFS_XFLAG_NOATIME;
- if (flags & LINUX_XFLAG_NODUMP)
+ if (flags & FS_NODUMP_FL)
xflags |= XFS_XFLAG_NODUMP;
else
xflags &= ~XFS_XFLAG_NODUMP;
next prev parent reply other threads:[~2006-12-14 18:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-14 18:04 [PATCH] use vfs-defined file attribute flags Eric Sandeen
2006-12-14 18:15 ` Christoph Hellwig
2006-12-14 18:18 ` Eric Sandeen
2006-12-14 18:21 ` Eric Sandeen [this message]
2006-12-19 16:53 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45819630.3070701@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.