All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Scott Preece <sepreece@gmail.com>
Cc: lkml <linux-kernel@vger.kernel.org>, akpm <akpm@osdl.org>,
	jesper.juhl@gmail.com
Subject: Re: [PATCH/RFC] CodingStyle updates
Date: Thu, 14 Dec 2006 15:43:14 -0800	[thread overview]
Message-ID: <4581E192.3010108@oracle.com> (raw)
In-Reply-To: <7b69d1470612141533v6ea076ap7149dbabceeb8ab4@mail.gmail.com>

Scott Preece wrote:
[1]
>>  Outside of comments, documentation and except in Kconfig, spaces are 
>> never
>>  used for indentation, and the above example is deliberately broken.
> ---
> 
> I realize it isn't text you added, but what's that supposed to mean?
> Surely the 8-character indents are made up of spaces.  Does it mean

No, the 8-character indents are made of one ASCII TAB character.

> "spaces other than 8-space blocks"? In any case, how does it synch
> with the following chapter's statement that continuations " are placed
> substantially to the right" - isn't that done with spaces, too?

That's usually (preferably) done with tab(s).  Sometimes it is done
with a few spaces instead.  (and we put up with it :)

> Or am I just totally spacing out on what was meant?

I take [1] to mean that this example:

	if (condition) do_this;
	  do_something_everytime;

is broken in at least 3 ways:
1/ do_this(); should be on a separate line;
2/ do_something_everytime() should not be indented more than the "if"
	above it; and
3/ *if* do_something_everytime() were to be indented more than it is,
	it should be done with a tab, not spaces.

-- 
~Randy

  reply	other threads:[~2006-12-14 23:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-07  8:48 [PATCH/RFC] CodingStyle updates Randy Dunlap
2006-12-07  8:54 ` Jesper Juhl
2006-12-07 11:11 ` Jan Engelhardt
2006-12-07 16:01   ` Chris Friesen
2006-12-07 18:27     ` Jan Engelhardt
2006-12-07 21:36       ` Randy Dunlap
2006-12-07 21:36   ` Randy Dunlap
2006-12-07 22:54 ` Alistair John Strachan
2006-12-07 23:00   ` Randy Dunlap
2006-12-07 23:06     ` David Miller
2006-12-07 23:15       ` Randy Dunlap
2006-12-07 23:23     ` Jan Engelhardt
2006-12-14 22:38 ` David Weinehall
2006-12-14 22:42   ` Randy Dunlap
2006-12-15  0:07     ` Robert P. J. Day
2006-12-15  0:26       ` Randy Dunlap
2006-12-15  0:44         ` Robert P. J. Day
2006-12-14 23:33 ` Scott Preece
2006-12-14 23:43   ` Randy Dunlap [this message]
2006-12-14 23:54     ` Scott Preece

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4581E192.3010108@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=akpm@osdl.org \
    --cc=jesper.juhl@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sepreece@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.