All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2] malloc: fix combined lib build
Date: Wed, 22 Jul 2015 10:26:58 +0200	[thread overview]
Message-ID: <4582360.pG3T7yarLt@xps13> (raw)
In-Reply-To: <1437474797-19778-1-git-send-email-sergio.gonzalez.monroy@intel.com>

> Malloc was moved to the EAL and dummy malloc library was left
> to not break apps that had a librte_malloc.so dependency.
> Note that the dummy library will be removed in the next release.
> 
> When building a combined library, all objects are copied to the same
> directory before creating the library itself.
> 
> There are a few issues:
>  - CONFIG_RTE_LIBRTE_MALLOC is not a valid option anymore resulting
>  in wrong syntax and a compilation failure. Fix it by replacing it
>  with CONFIG_RTE_LIBRTE_EAL.
>  - As we kept a dummy library, there are now two objects with the
>  same name. This means that the proper rte_malloc.o object in eal gets
>  overwritten by an empty rte_malloc.o object from the dummy malloc lib.
>  Fix it by changing the name of rte_malloc.o object in the dummy
>  library.
>  - Update the copyright year.
> 
> Fixes: 2f9d47013e4dbb738 ("mem: move librte_malloc to eal/common")
> 
> Reported-by: Alin Rauta <alin.rauta@intel.com>
> Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>

Applied, thanks

  reply	other threads:[~2015-07-22  8:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1437389608-18697-1-git-send-email-alin.rauta@intel.com>
2015-07-20 18:03 ` [PATCH] DPDK fails to build into one single library ("CONFIG_RTE_BUILD_COMBINE_LIBS=y") Rauta, Alin
2015-07-21 10:18   ` [PATCH] malloc: fix combined lib build Sergio Gonzalez Monroy
2015-07-21 10:18     ` Sergio Gonzalez Monroy
2015-07-21 10:20       ` Gonzalez Monroy, Sergio
2015-07-21 10:33     ` [PATCH v2] " Sergio Gonzalez Monroy
2015-07-22  8:26       ` Thomas Monjalon [this message]
     [not found] ` <1437389608-18697-2-git-send-email-alin.rauta@intel.com>
2015-07-20 18:04   ` [PATCH] DPDK fails to build into one single library ("CONFIG_RTE_BUILD_COMBINE_LIBS=y") Rauta, Alin
2015-07-20 18:14     ` Thomas Monjalon
2015-07-21  9:49       ` Rauta, Alin
2015-07-21  9:53         ` Gonzalez Monroy, Sergio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4582360.pG3T7yarLt@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=sergio.gonzalez.monroy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.