From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jes Sorensen <jes@sgi.com>
Subject: [patch] ram scrub: only print dot for actual memory
Date: Fri, 15 Dec 2006 13:59:55 +0100
Message-ID: <45829C4B.9030109@sgi.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="------------070608000402080508000701"
Return-path: <xen-devel-bounces@lists.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: keir@xensource.com
Cc: xen-devel@lists.xensource.com, alex.williamson@hp.com
List-Id: xen-devel@lists.xenproject.org

This is a multi-part message in MIME format.
--------------070608000402080508000701
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Hi Keir,

I would like to propose we reorganize the code in scrub_heap_pages()
slightly so it only prints a dot for pages that are actually present.

For those of us who have hugely sparse physical memory maps, this saves
printing a couple of hundred lines of dots at boot time.

Cheers,
Jes

--------------070608000402080508000701
Content-Type: text/plain;
 name="xen-ram-scrub.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="xen-ram-scrub.diff"

# HG changeset patch
# User jes@eye.emea.sgi.com
# Date 1166187377 -3600
# Node ID 38bae9f2448d6d694eaea626db0bb63b75fdd1b2
# Parent  fd3e080a4f54d1fbb4a1518a05508262b7ab3fce
free-mem-scrubbing: only print dots for actual memory

Signed-off-by: Jes Sorensen <jes@sgi.com>

diff -r fd3e080a4f54 -r 38bae9f2448d xen/common/page_alloc.c
--- a/xen/common/page_alloc.c	Fri Dec 15 13:50:24 2006 +0100
+++ b/xen/common/page_alloc.c	Fri Dec 15 13:56:17 2006 +0100
@@ -493,15 +493,15 @@ void scrub_heap_pages(void)
 
     for ( pfn = first_pg; pfn < max_page; pfn++ )
     {
+        process_pending_timers();
+
+        /* Quick lock-free check. */
+        if ( allocated_in_map(pfn) )
+            continue;
+
         /* Every 100MB, print a progress dot. */
         if ( (pfn % ((100*1024*1024)/PAGE_SIZE)) == 0 )
             printk(".");
-
-        process_pending_timers();
-
-        /* Quick lock-free check. */
-        if ( allocated_in_map(pfn) )
-            continue;
 
         spin_lock_irq(&heap_lock);
 

--------------070608000402080508000701
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

--------------070608000402080508000701--