From: Boris Itkis (Linux) <borisitk@fortunet.com>
To: buildroot@busybox.net
Subject: [Buildroot] Problem with building sudo
Date: Fri, 15 Dec 2006 10:14:27 -0800 [thread overview]
Message-ID: <4582E603.7090204@fortunet.com> (raw)
In-Reply-To: <20061215152921.GB14633@aon.at>
Bernhard Fischer wrote:
> On Fri, Dec 15, 2006 at 04:10:39PM +0100, Bernhard Fischer wrote:
>
>> On Fri, Dec 08, 2006 at 01:32:35PM -0800, Boris Itkis (Linux) wrote:
>>
>>> sudu.mk has a problem for building:
>>>
>>> $(TARGET_DIR)/usr/bin/sudo
>>>
>>> it echo's the command to install sudu instead of running it.
>>>
>> I'll look into this.
>>
>
> Can you update and retry? The installation is done via fakeroot, sudo
> didn't depend on fakeroot so may not be built for you, depending on your
> config.
>
>
The Part I am Refering to is:
$(TARGET_DIR)/usr/bin/sudo: $(SUDO_DIR)/sudo
# Use fakeroot to pretend to do 'make install' as root
echo "$(MAKE) $(TARGET_CONFIGURE_OPTS) DESTDIR="$(TARGET_DIR)" -C $(SUDO_DIR) install" \
> $(STAGING_DIR)/.fakeroot.sudo
touch -c $(TARGET_DIR)/usr/bin/sudo
If you execute ${STAGING_DIR)/.fakeroot.sudo it does the installation
correctly.
May I suggest that you change:
echo "$(MAKE) $(TARGET_CONFIGURE_OPTS) DESTDIR="$(TARGET_DIR)" -C $(SUDO_DIR) install" \
> $(STAGING_DIR)/.fakeroot.sudo
to:
$(MAKE) $(TARGET_CONFIGURE_OPTS) DESTDIR="$(TARGET_DIR)" -C $(SUDO_DIR) install \
> $(STAGING_DIR)/.fakeroot.sudo
I believe that should fix the problem of not automatically installing sudo:
>>> It generally does not stop compile because on distributions like fedora
>>> because "touch -c" has a exit code of 0 even if the file does no exist.
>>>
>> That's a bug.
>>
>
> Nah, it's of course not. Not exiting with ACK would have been.
> Note to self: the character '0' denotes 0, not 1 ;)
>
>
>
This is or is not a bug depending on your perspective. If one just
wishes to display to the user that there is a problem and possibly stop
compilation then it's not a bug. If one wants to always stop if the file
does not exist then it is a bug.
If one believes this is a bug then may I suggest that "touch -c" be
changed to "test -f" or add a "test -f" line after the "touch -c" line.
next prev parent reply other threads:[~2006-12-15 18:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-08 21:32 [Buildroot] Problem with building sudo Boris Itkis
2006-12-15 15:10 ` Bernhard Fischer
2006-12-15 15:29 ` Bernhard Fischer
2006-12-15 18:14 ` Boris Itkis [this message]
2006-12-20 18:28 ` Bernhard Fischer
2006-12-20 22:04 ` Boris Itkis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4582E603.7090204@fortunet.com \
--to=borisitk@fortunet.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.